@georgehrke here is the PR of the first branch

So allot of failings is due to ther merge commit 4e74cfc. I'm totaly failing in removing it.
Edit: Solved by rebasing on nextcloud/master

And in the @ since errors can I add @ since 14.0.0 or is there a dummy like @ since notclear.

Codecov Report

Merging #7996 into master will decrease coverage by 45.19%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #7996      +/-   ##
===========================================
- Coverage      51.7%   6.51%   -45.2%     
- Complexity    25429   25499      +70     
===========================================
  Files          1598    1601       +3     
  Lines         95248   95591     +343     
  Branches       1376    1376              
===========================================
- Hits          49252    6225   -43027     
- Misses        45996   89366   +43370

Could somebody pleas add the help needed label?

OK forgot about the new external dependency gnupg.

There is a second implementation which could use as external dependency https://github.com/pear/Crypt_GPG.
Which at the moment I'm using the fist one, but I think it shoudln't be to much work implementing the second one or supporting both. For nextcloud internal everything calls the IGpg class.

So which of the external dependency's is to one is to prefer?
And how can it be added to the nextcloud dependencys?

@jospoortvliet This is a first-time contributor seeking for help. Perhaps you can find somebody who could give a few hints and feedback if such an enhancement could be integrated in NC 14.

Hi @tacruc

first of all thanks for your contribution and thanks and sorry for the late reply.

@MorrisJobke and I have been discussing this and we don't think we want to merge this into the main server. It is a lot of extra code we'd have to test and maintain.

Would it be possible for you to see if we can at some points in the code add events or plugins so this can be handled in an app? That way we can nicely isolate all behavior.

Feel free to open an issue to discuss this in more details.

Hi @rullzer,
thanks for your reply. I already expected this answer and can understand it, looking at the number of people using GPG. But I would still like this feature.

My problem is a little bit, that I think the more code I move into an app, the less user friendly the behavior will get, because in the end one can't automate the decision which Email to encrypt and which key to use. This is a decision the user would have to make on the event triggering the email.

So I think the changes to the email Interface, to enable not only to pass an email as address, but to pass a optional key, would be nice to integrate it in the core of the server.
All the stuff handling the key's and the email encryption can then be handled by an app.

So the solution with the max needed changes to the core would be something like the dummyGPG interface. Which than triggers the app. On the other extreme it would be an encryption gateway hooked, to the email send function, and does the automate the decision based on known public key's for the email address. In this extreme the app woudn't know which user has triggered the email, so having one user importing an public key for alice would probably end up in every user sending encrypted emails to alice, which could be used to brake the email system, when a bad user imports random public keys for all known email addresses.

I would be willing to split the code into a server and an app part, but I think the boarder should be chosen wise. If your interested we could have a talk or I could join the next hack week to work out wich is the best line to split.

@tacruc hey, if you still want to work on this, perhaps you join the conference so we can make some decisions? The hackweek would have been nice, too, of course - otherwise, just come to the next, there will be another before the end of the year for sure 🚀

@jospoortvliet I'm still interested in continuing and already thought about the conference, but I can't make it this time. But hopefully I can make it to the next Hack week.