Assign users to cards by juliusknorr · Pull Request #314 · nextcloud/deck

juliusknorr · 2017-10-01T14:17:12Z

This implements #11

TODO:

Show avatars in board view
Show only users that are not already assigned
~~Notify only assigned users (requires Add notifications for overdue cards and board sharing #309)~~ Lets notify all for now
Fix tests

codecov · 2017-10-10T17:35:14Z

Codecov Report

Merging #314 into master will increase coverage by 1.38%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   76.83%   78.22%   +1.38%     
==========================================
  Files          36       38       +2     
  Lines        1131     1194      +63     
==========================================
+ Hits          869      934      +65     
+ Misses        262      260       -2

juliusknorr · 2017-10-11T13:18:36Z

This is ready for testing/review. @pixelipo @artemanufrij Would be cool if you could give it a try.

Also cc @terrar @ossie @poVoq

pixelipo

Works quite nicely! Good work, @juliushaertl

I've just made a few small comments regarding CSS

pixelipo · 2017-10-13T10:52:35Z

 		position: relative;

 		.card-options {
-			opacity: 0.3;


we still need this one, I think (but maybe it should be 0.5 instead).

pixelipo · 2017-10-13T11:08:16Z


-        <ui-select ng-if="boardservice.canShare()" ng-model="status.addSharee" theme="select2" style="width:100%;" title="Choose a user to assign" placeholder="Assign users ..." on-select="aclAdd(status.addSharee)" search-enabled="true">
+        <ui-select ng-if="boardservice.canShare()" ng-model="status.addSharee" theme="select2" style="width:100%;"
+				   title="Choose a user to assign" placeholder="Assign users ..."


missing translation strings

pixelipo · 2017-10-13T11:09:44Z

    <div id="commentsTabView" class="tab commentsTabView" ng-if="status.boardtab==0 || !status.boardtab">

-        <ui-select ng-if="boardservice.canShare()" ng-model="status.addSharee" theme="select2" style="width:100%;" title="Choose a user to assign" placeholder="Assign users ..." on-select="aclAdd(status.addSharee)" search-enabled="true">
+        <ui-select ng-if="boardservice.canShare()" ng-model="status.addSharee" theme="select2" style="width:100%;"


is the inline style (width) really needed here?

pixelipo · 2017-10-13T11:18:48Z

+		display: flex;
+		margin-bottom: 5px;
+		margin-top: 20px;
+		min-height: 30px;


is min-height really needed?

pixelipo · 2017-10-13T11:19:14Z

+		h4 {
+			padding-top: 5px;
+			padding-bottom: 5px;
+			border: none;


not needed?

pixelipo · 2017-10-13T11:19:37Z

+			border: none;
+			flex: 1;
 		}
+


Empty lines

pixelipo · 2017-10-13T11:29:01Z

@juliushaertl I made a couple of commits here, I hope you don't mind. I think they make the whole .card-controls bar a bit cleaner and more consistent:

it's actually 2px smaller now, to a standard 44px used throughout NC
.icon-more icon is now more touchscreen-friendly, with and activation area of 44x44px
avatars are 32px standard size without affecting overall height

juliusknorr · 2017-10-16T07:52:30Z

Thanks for the commits. There is a small issue when no card description is set. I'll take care of that.

Fixed.

juliusknorr · 2017-10-18T14:11:07Z

@pixelipo Fixed. Thank you.

ossie · 2017-10-22T12:41:50Z

@juliushaertl I checked out pr #314 and tried to assign users: Fetching the user list fails.
I keep getting JS errors: [$injector:unpr] http://errors.angularjs.org/1.6.4/$injector/unpr?p0=withoutAssignedUsersFilterProvider%20%3C-%20withoutAssignedUsersFilter.
Users assigned directly in the database look fine, though.

Signed-off-by: Julius Härtl <[email protected]>

Signed-off-by: Marin Treselj <[email protected]>

Signed-off-by: Julius Härtl <[email protected]>

juliusknorr · 2017-10-23T19:19:59Z

@ossie Thanks for giving it a try. That migh be caused when trying it before 9b54d1c#diff-70c43e8d89ea7f7d5e64f83246f17ed0R50 was added to the PR, and running in debug mode. At least i could not reproduce it anymore. Let's merge now. Feel free to open an issue if that sill occurs on master.

juliusknorr added 2. developing enhancement labels Oct 1, 2017

juliusknorr added this to the 0.3.0 milestone Oct 1, 2017

juliusknorr force-pushed the assign-users branch 2 times, most recently from b763794 to 7c4d62f Compare October 3, 2017 21:10

juliusknorr force-pushed the assign-users branch from 500a184 to 9d10644 Compare October 10, 2017 17:34

juliusknorr force-pushed the assign-users branch 3 times, most recently from f248e8f to 7c8532c Compare October 11, 2017 12:56

juliusknorr added 3. to review and removed 2. developing labels Oct 11, 2017

pixelipo self-requested a review October 13, 2017 10:19

pixelipo previously requested changes Oct 13, 2017

View reviewed changes

juliusknorr mentioned this pull request Oct 16, 2017

Integrate with notifications app #18

Closed

2 of 4 tasks

juliusknorr self-assigned this Oct 16, 2017

juliusknorr removed their assignment Oct 18, 2017

juliusknorr force-pushed the assign-users branch from 09d6580 to 1dcc664 Compare October 18, 2017 14:11

pixelipo approved these changes Oct 23, 2017

View reviewed changes

juliusknorr added 5 commits October 23, 2017 21:15

WIP: assign users

bf1927d

Signed-off-by: Julius Härtl <[email protected]>

Fix card headings

bf3dad5

Signed-off-by: Julius Härtl <[email protected]>

Backend: Get list of users to assign

c9ac13f

Signed-off-by: Julius Härtl <[email protected]>

Frontend: Add UI for user assignment

a889a68

Signed-off-by: Julius Härtl <[email protected]>

Backend: assign/remove user impelementation

b15bbbd

Signed-off-by: Julius Härtl <[email protected]>

juliusknorr and others added 16 commits October 23, 2017 21:18

Frontend: Fix assigning/removing users

fb3fd67

Signed-off-by: Julius Härtl <[email protected]>

Frontend: cleanup dom structure and css

e20acd1

Signed-off-by: Julius Härtl <[email protected]>

Card: Show assigned users on board

98414b0

Signed-off-by: Julius Härtl <[email protected]>

Tests: Fix tests for user assignment

7f75d17

Signed-off-by: Julius Härtl <[email protected]>

Frontend: Fix codacy errors

05b92c1

Signed-off-by: Julius Härtl <[email protected]>

Fix issue with new findUser implementation

9d9e7fc

Signed-off-by: Julius Härtl <[email protected]>

Fix tests that invoke findUsers

1714fa3

Signed-off-by: Julius Härtl <[email protected]>

Fix inspection issues

0edc451

Signed-off-by: Julius Härtl <[email protected]>

Card: Only show users that are not already assigned

d2e1deb

Signed-off-by: Julius Härtl <[email protected]>

Tests: Add integration test for user assignment

d4eaa2d

Signed-off-by: Julius Härtl <[email protected]>

Frontend: fix warnings in withoutAssignedUsers filter

9ee7150

Signed-off-by: Julius Härtl <[email protected]>

Use default (larger) avatar size, default (smaller) action bar height

82c4048

Signed-off-by: Marin Treselj <[email protected]>

Give 44*44px clickable area for the icon-more button

a744eb5

Signed-off-by: Marin Treselj <[email protected]>

Add some space between multiple assignees

24b5263

Signed-off-by: Marin Treselj <[email protected]>

Card: Fix styling issue when only duedate is set

915cde4

Signed-off-by: Julius Härtl <[email protected]>

Frontend: Remove unrequired css and fix language strings

8f835f5

Signed-off-by: Julius Härtl <[email protected]>

juliusknorr force-pushed the assign-users branch from 1dcc664 to 8f835f5 Compare October 23, 2017 19:18

juliusknorr merged commit 53b1af9 into master Oct 23, 2017

juliusknorr deleted the assign-users branch October 23, 2017 20:12

juliusknorr mentioned this pull request Oct 23, 2017

Assign users to cards [$85 awarded] #11

Closed

juliusknorr mentioned this pull request Dec 5, 2017

Assign a card to a team member (Feature Request) #349

Closed

Conversation

juliusknorr commented Oct 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Oct 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

juliusknorr commented Oct 11, 2017

Uh oh!

pixelipo left a comment

Choose a reason for hiding this comment

Uh oh!

pixelipo Oct 13, 2017

Choose a reason for hiding this comment

Uh oh!

pixelipo Oct 13, 2017

Choose a reason for hiding this comment

Uh oh!

pixelipo Oct 13, 2017

Choose a reason for hiding this comment

Uh oh!

pixelipo Oct 13, 2017

Choose a reason for hiding this comment

Uh oh!

pixelipo Oct 13, 2017

Choose a reason for hiding this comment

Uh oh!

pixelipo Oct 13, 2017

Choose a reason for hiding this comment

Uh oh!

pixelipo commented Oct 13, 2017

Uh oh!

juliusknorr commented Oct 16, 2017

Uh oh!

juliusknorr commented Oct 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ossie commented Oct 22, 2017

Uh oh!

juliusknorr commented Oct 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

juliusknorr commented Oct 1, 2017 •

edited

Loading

codecov Bot commented Oct 10, 2017 •

edited

Loading

juliusknorr commented Oct 18, 2017 •

edited

Loading