Repository navigation
In grid view, file type icons are too big compared to image previews #11902
Description
Activity
Should easily doable just with some CSS:
[data-has-preview='false'] .thumbnail { background-size:50% !important; }Reacted by Jan C. BorchardtWhat kind of ratio do you think is good? 50% as Julius set?
I can have a look if this is possible on AndroidI think 50% is already a bit to small, 75% looks good to me. Also I would actually only apply this to the grid view.
Reacted by Roeland Jago Douma, Jan C. Borchardt, Tobias Kaminsky, Andy Scherzinger and John MolakvoæSounds good to me @juliushaertl, thanks for the piece of code! :) I'll play around with the values a bit tomorrow, or do you already want to submit a pull request with 75% and we can discuss there?
I am shameless posting an android screenshot here…
As you can see, I only resized the folder, but not generic mimetypes.
How do you do this on webUI?Reacted by Jan C. Borchardt and John Molakvoæ@tobiasKaminsky nice, already looks much better! It's really visible how the folder icon size looks nicer in comparison to the rest.
- The other filetype icons also need to be smaller
- The text below can be moved up a bit (towards the filetype icon)
- Text size is also a bit large maybe? Is it the same as the file name in list view?
(And it's absolutely fine posting the Android screenshots here :) It's an issue we have cross-platform and wr should solve it generally. Actually probably similar for the iOS grid view, cc @marinofaggiana)
In general, I am not sure if text/filename in grid view is really useful.
According to all screenshots in this issue (Independent from platform), you can always read only ~5 chars at beginning and a few on the end and this does not help to distinguish:- on first one multiple "Screen…"
- on android multiple nextcl…apk
Unfortunately I do not have a better idea.
Maybe putting "…" to the end, as you can see the mimetype through icons, but in case of last iOS image, scan 16/43 would then be trimmed…New grid with more Width for item, generally 3 item for line ... now the filename has more meaning
@jancborchardt margin left and right now are 5 px (?) or 0 ?
47 remaining items
Fixed 28. Much more elegant nowI cannot spot any difference? 😇
@jancborchardt as this is also interesting for Android, how small shall e.g. the folder icon be?Might also be the general spacing that makes it look much better. Nice :)
@tobiasKaminsky I just checked Android and the sizing of the icons compared to the previews seems fine to me.
In the new grid view, the filetype icons look unelegantly large compared to the image previews (This is actually also the case in the Android app which uses the same previews & folder icons cc @tobiasKaminsky @AndyScherzinger)
In the list view it’s fine, although it would not be bad for the preview images to be bigger:
How can we reduce the size of the filetype icons / make the image previews larger? @rullzer @nextcloud/designers