The icon of new comment in the share is missing #12027

Activity

1. nextcloud-bot

   added

   designDesign, UI, UX, etc.Design, UI, UX, etc.

   feature: comments

   feature: sharing

   on Oct 25, 2018
2. nextcloud-bot commented on Oct 25, 2018

   

   nextcloud-bot

   on Oct 25, 2018

   Member

   More actions

   GitMate.io thinks possibly related issues are #2277 (Sharing icon seems missing), #10877 (Comment icon is not shown on shared folder), #10583 (Icon "confirm-white" is missing), #10886 (NC14 RC1: unread comments icon with the Share User unvisible), and #4218 (Missing audio icon).
3. nextcloud-bot

   added

   enhancement

   on Oct 25, 2018
4. skjnldsv commented on Nov 19, 2018

   

   skjnldsv

   on Nov 19, 2018

   Member

   More actions

   @plyaskin Hey!
   I'm not sure I get what you mean, the icon is shown when we have an unread comment, you want to add it all the time, having unread comment or not?
5. skjnldsv

   added

   needs info

   on Nov 19, 2018
6. rullzer commented on Nov 22, 2018

   

   rullzer

   on Nov 22, 2018

   Member

   More actions

   @skjnldsv I could reproduce this (at least on master).

   1. userA shares a folder to userB
   2. userA adds a comment
   3. userB refreses sees no comment
   4. userB adds a comment
   5. userA refresesh sees no comment

   I could get it to show once. But in general it is not visible properly.
7. skjnldsv commented on Nov 22, 2018

   

   skjnldsv

   on Nov 22, 2018

   Member

   More actions

   @rullzer grid view?
8. rullzer commented on Nov 22, 2018

   

   rullzer

   on Nov 22, 2018

   Member

   More actions

   List view
9. MorrisJobke

   removed

   needs info

   on Nov 29, 2018
10. skjnldsv

    self-assigned this

    on Dec 4, 2018
11. skjnldsv

    added this to the Nextcloud 15.0.1 milestone on Dec 4, 2018
12. skjnldsv commented on Dec 6, 2018

    

    skjnldsv

    on Dec 6, 2018

    Last edited by skjnldsv

    Member

    More actions

    1. Create a folder as User0: ID is 198
    2. Add comment as User0
    3. Share folder to User1
    4. As User1 check files: see folder. ID is 198

    On load

    User0 getNumberOfUnreadCommentsForFolder request the node ID 2
    User1 getNumberOfUnreadCommentsForFolder request the node ID 191
    🤔 First issue, we don't request the same ID

    On the filecache database

    The folder id is properly defined to 198, we also have a parent column which is set to 2
    This is why it only works in a single direction, if User1 post a comment, User0 will have the icon, not the other way around

    The getNumberOfUnreadCommentsForFolder join the comment table on the parent id (wtf is this?)
13. skjnldsv commented on Dec 6, 2018

    

    skjnldsv

    on Dec 6, 2018

    Member

    More actions

    More input, I get it now, we get all the unread comments of the content of the parent directory. Make sense.
    Then this is the issue. The parent directory of the User1 is not the same as User0, therefore we cannot get the unread count! @rullzer
14. rullzer

    closed this as completedin #12897on Dec 7, 2018
15. MorrisJobke

    modified the milestones: Nextcloud 15.0.1, Nextcloud 15 on Dec 7, 2018