Skip to content

Signature Panel #1213

Closed
Closed
Signature Panel#1213
Labels
1. to developAccepted and waiting to be taken care ofenhancementfeature: sharingstandardization

Description

@blizzz
blizzz
opened on Aug 31, 2016

Signature panel

The Signature panel allows users of a file to mark it as accepted/rejected. This is useful and targeted for auditing purposes. File owners/Sharer sees the state of each sharee.

Requirements

  • add signature check box to sharing dialog (per sharee).
  • notification are sent out with signature box ticking. Notification should bring you to the file, signature tab.
    shares with signature enabled have signature tab in sidebar
  • support remote shares
  • Sharer sees full list of sharees and their state (Received, Accepted, Rejected). Groups expandable.
  • Sharee sees only its state and action buttons/slider: (Received/Neutral,) Accepted, Rejected (undoable)
  • Reset state on file update
  • Show done action in activity feed
  • Keep Signatures for old file versions, depending on versions_app enabled. Save the file version internally (e.g. within the object id by using comments infrastructure, or as json in message body). Clean up after deleted file versions.

Nice to have

  • Tweak the version tab to show signature state

Feedback appreciated @oparoz @jancborchardt @nickvergessen @schiessle

Activity

  1. blizzz
    added
    enhancement
    1. to developAccepted and waiting to be taken care of
    spec
    on Aug 31, 2016
  2. blizzz
    added this to the Nextcloud 11.0 milestone on Aug 31, 2016
  3. blizzz
    added
    feature: sharing
    on Aug 31, 2016

  4. blizzz commented on Sep 20, 2016

    @blizzz
    blizzz
    on Sep 20, 2016
    MemberAuthor

    Discussion with @schiessle @jancborchardt @oparoz and me at Nextcloud conf:

    • no extra tab, integrate with Sharing and add as Sharing option in Sharing app
    • requires Move sharing options into popover menu #607, option to add per sharee in the 3-dot-menu
    • requires 3-dot-menu in Details Sidebar (integrate local links, tags¹), precondition
    • add drop-down to 3-dot-menu (approve, undecided, reject)
    • add icon indicator to file row (like for new comments)

    ¹tags input field not shown when no tags are assigned, otherwise it stays like it is currently

    cc @nickvergessen (fyi, 3-dot-menu in details sidebar)

  5. MorrisJobke
    modified the milestones: Nextcloud 12.0, Nextcloud 11.0 on Nov 24, 2016

  6. jospoortvliet commented on Apr 21, 2017

    @jospoortvliet
    jospoortvliet
    on Apr 21, 2017
    Member

    @jancborchardt any chance you can do a mockup 💃

  7. MorrisJobke commented on Apr 30, 2017

    @MorrisJobke
    MorrisJobke
    on Apr 30, 2017
    Member

    @blizzz @karlitschek I guess it's not feasible within the scope of 12 -> moved to 13

  8. MorrisJobke
    modified the milestones: Nextcloud 13, Nextcloud 12.0 on Apr 30, 2017

  9. karlitschek commented on May 1, 2017

    @karlitschek
    karlitschek
    on May 1, 2017
    Member

    ok

  10. MorrisJobke
    removed this from the Nextcloud 13 milestone on Nov 13, 2017
  11. nextcloud-bot
    added
    staleTicket or PR with no recent activity
    on Jun 20, 2018
  12. skjnldsv
    removed
    staleTicket or PR with no recent activity
    on Jun 12, 2019

  13. szaimen commented on May 21, 2021

    @szaimen
    szaimen
    on May 21, 2021
    Contributor

    I'm closing this issue due to inactivity. Please reopen if you still want to implement this.

  14. szaimen
    closed this as completedon May 21, 2021

  15. nickvergessen commented on May 21, 2021

    @nickvergessen
    nickvergessen
    on May 21, 2021
    Member

    Similar replacement could be https://github.com/eneiluj/approval

  16. susnux
    added
    standardization
    and removed
    spec
    on Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    1. to developAccepted and waiting to be taken care ofenhancementfeature: sharingstandardization

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions