Move sharing options into popover menu - #607

@ChristophWurst, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81, @blizzz and @schiessle to be potential reviewers

having this new drop-down menu for the additional share permissions looks great. But I would keep the "unshare" button out. This makes it way more easier to unshare multiple files in a row.

Awesome!
But I agree with @schiessle for the unshare button.

Btw why is can edit not in the dropdown?

Btw why is can edit not in the dropdown?

Because it's used more frequently according to @jancborchardt

Because it's used more frequently according to @jancborchardt

And it is a meta permission. Can edit includes all the other ones, right?

can edit does not cover can share...

»can edit« is outside of the dropdown because deciding if you share something with a person read-only or with full access is arguably an important decision. It should not be hidden away in a dropdown.

Agree that we can keep the »Unshare« button out of the dropdown for now. So it should look like this:

😎 Hans           [ ] can edit  •••  🗑

😃 Maria          [x] can edit  •••  🗑

What we should also do:

• Sort people with most permissions up top (those with edit rights)
• rename »can share« to »can reshare« so it’s more clear

I think the can reshare should also be out of the dropdown. It is an essential permission.

Ah it is because of some of the js magic. Let me fix it :)

Should work now ;)

Some things:

• Can we move the ... and trash icon all the way to the right?
• Can we make the menu appear on the dots?

It now looks like this. Which I think is very nice!
Only thing I really dislike here is the trashbin next to the dot menu... way to easy to click on it....

@jancborchardt suggestions?

Only thing I really dislike here is the trashbin next to the dot menu... way to easy to click on it....

And the alignment is a bit off.

From #146

• Rename edit to upload and edit

Never mind was for link sharing

@MorrisJobke yeah I leave all that to somebody with a bit more CSS fu ;)

Only thing I really dislike here is the trashbin next to the dot menu... way to easy to click on it....

@rullzer ;D exactly the reason why I would have moved it into the menu. ;) But a bit of spacing might take care of it as well.

@ChristophWurst @rullzer What is the status of this? Could I somehow help here?

@MorrisJobke ah yes. The aligning is still a bit off and we probabaly need more spacing between the delete button.

Awesome if you could take care :)

@MorrisJobke @rullzer what's the status of this now? Anything left that needs to be done?

@MorrisJobke @rullzer what's the status of this now? Anything left that needs to be done?

Rullzer asked if I could help with the layout. I haven't looked at it yet.

Fixed the alignment and added some padding to the unshare icon:

@ChristophWurst thnx!

I'd say lets get this in! We can sort out details later. Longer we wait the more conflicts and stuff will pop up.

SO LGTM!

Current coverage is 30.59% (diff: 100%)

Merging #607 into master will not change coverage

@@             master       #607   diff @@
==========================================
  Files          1081       1081          
  Lines         60020      60020          
  Methods        6808       6808          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          18362      18362          
  Misses        41658      41658          
  Partials          0          0          

Powered by Codecov. Last update 07a1be2...96af627

LGTM

@ChristophWurst FYI https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md#sign-your-work