Skip to content

Floating file header jumps to top on sorting #15438

Closed

Description

@tobiasKaminsky
  • scroll down a bit
  • click on a table header e.g. Date for sorting
  • see that file list jumps to top

instead it position should remain, but only content should change.

Activity

  1. added this to the Nextcloud 17 milestone on May 9, 2019
  2. modified the milestones: Nextcloud 17.0.4, on Mar 11, 2020
  3. modified the milestones: , Nextcloud 17.0.6 on Mar 23, 2020
  4. 17 remaining items

  5. added
    1. to developAccepted and waiting to be taken care of
    and removed
    0. Needs triagePending check for reproducibility or if it fits our roadmap
    on Mar 1, 2023
  6. self-assigned this
    on Mar 1, 2023
  7. skjnldsv commented on Mar 2, 2023

    @skjnldsv
    Member

    What should be the expected behaviour btw, if you sort everything, keeping the scrolling position would most likely not show the relevancy the user is looking for?

  8. tobiasKaminsky commented on Mar 2, 2023

    @tobiasKaminsky
    MemberAuthor

    instead it position should remain, but only content should change.

    This is what I am used to on other file listings, e.g. Dolphin on Linux, or Thunderbird.

  9. skjnldsv commented on Mar 2, 2023

    @skjnldsv
    Member

    Good from me 🤷‍♂️
    @jancborchardt @nimishavijay, you good with that?

  10. nimishavijay commented on Mar 2, 2023

    @nimishavijay
    Member

    🤔 what @skjnldsv said about scrolling to show relevant info makes sense to me as well, on checking other apps it truly is a mixed bag. Windows file explorer and Google Drive scroll on changing sort order, while Dropbox, Nautilus on Ubuntu and the other apps @tobiasKaminsky mentioned don't scroll. I would go with scrolling for same reason @skjnldsv mentioned, ccing @jancborchardt here

  11. jancborchardt commented on Mar 2, 2023

    @jancborchardt
    Member

    We do a hard refresh on re-sorting, so pretty difficult to keep the position anyway?

    I would also agree with @skjnldsv and @nimishavijay’s research in that it makes a bit more sense to scroll to top since the whole content changed.

    A quick animation that scrolls to the top of the list would of course be nice, but yeah with the hard refresh it’s difficult.

  12. skjnldsv commented on Mar 2, 2023

    @skjnldsv
    Member

    We do a hard refresh on re-sorting, so pretty difficult to keep the position anyway?

    There is some options possible. It's easy to remember the top-to-scroll-position pixel amount, but depending on what we wanna achieve, some stuff can and can't be done :)

    What about this:

    1. If a file is focused, we scroll to its position on a sorting change
    2. If a file is selected (or a group) we scroll to the first selected item
    3. If there is is none, we scroll up top
  13. skjnldsv commented on Mar 2, 2023

    @skjnldsv
    Member

    A quick animation that scrolls to the top of the list would of course be nice, but yeah with the hard refresh it’s difficult.

    Also, keep in mind files to vue is still ongoing, a hard refresh might be avoidable here (just re-rendering might be possible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions