Expandable Tags entry in navigation

In Favorites you can pin folders and files. This work fine when you have an file hierarchy structure. together with automatic labeling and other stuff that will be possible with 18, it would be useful to favorite labels like an todo label. So you have all your stuff labels with todo with one click available.

The "Tags" category should be expandable just like Favorites as well, showing the tags below it. Someone just has to implement it – it’s not planned yet so any help is welcome. :)

As favorite and shares are expandable, yes it would be good to have the sidebar consistent and make labels also consistent expandable.

@newhinton

@newhinton let me know if you need any input here! :) For the first iteration, it should definitely be single-select of tags only, that is clicking another tag should switch to that. Nothing more for the first version to keep it simple. :)

@jancborchardt

@jancborchardt considering this is directly the list of tags and that with 28 we now display them like folders, do we still want this?
I'm afraid this can easily get messy with too many tags :)
And the backend doesn't allow us to actually favorite tags 🤔

Does the backend directly know how many times a tag is used? Cause then we could show the top X tags in there for quick access.

@blizzz

I think there is a way, but it should be done async, as this could be expensive 🤔
@blizzz, do you know about this, how performant can this be?

server/apps/dav/lib/SystemTag/SystemTagsInUseCollection.php

Lines 82 to 107 in 6714e51

    
           public function getChildren(): array { 
        
           	$user = $this->userSession->getUser(); 
        
           	$userFolder = null; 
        
           	try { 
        
           		if ($user) { 
        
           			$userFolder = $this->rootFolder->getUserFolder($user->getUID()); 
        
           		} 
        
           	} catch (NoUserException) { 
        
           		// will throw a Sabre exception in the next step. 
        
           	} 
        
           	if ($user === null || $userFolder === null) { 
        
           		throw new Forbidden('Permission denied to read this collection'); 
        
           	} 
        
           	$result = $this->systemTagsInFilesDetector->detectAssignedSystemTagsIn($userFolder, $this->mediaType); 
        
           	$children = []; 
        
           	foreach ($result as $tagData) { 
        
           		$tag = new SystemTag((string)$tagData['id'], $tagData['name'], (bool)$tagData['visibility'], (bool)$tagData['editable']); 
        
           		// read only, so we can submit the isAdmin parameter as false generally 
        
           		$node = new SystemTagNode($tag, $user, false, $this->systemTagManager); 
        
           		$node->setNumberOfFiles((int) $tagData['number_files']); 
        
           		$node->setReferenceFileId((int) $tagData['ref_file_id']); 
        
           		$children[] = $node; 
        
           	} 
        
           	return $children; 
        
           }

server/lib/private/Files/Cache/CacheQueryBuilder.php

Lines 44 to 61 in 0fca823

    
           public function selectTagUsage(): self { 
        
           	$this 
        
           		->select('systemtag.name', 'systemtag.id', 'systemtag.visibility', 'systemtag.editable') 
        
           		->selectAlias($this->createFunction('COUNT(filecache.fileid)'), 'number_files') 
        
           		->selectAlias($this->createFunction('MAX(filecache.fileid)'), 'ref_file_id') 
        
           		->from('filecache', 'filecache') 
        
           		->leftJoin('filecache', 'systemtag_object_mapping', 'systemtagmap', $this->expr()->andX( 
        
           			$this->expr()->eq('filecache.fileid', $this->expr()->castColumn('systemtagmap.objectid', IQueryBuilder::PARAM_INT)), 
        
           			$this->expr()->eq('systemtagmap.objecttype', $this->createNamedParameter('files')) 
        
           		)) 
        
           		->leftJoin('systemtagmap', 'systemtag', 'systemtag', $this->expr()->andX( 
        
           			$this->expr()->eq('systemtag.id', 'systemtagmap.systemtagid'), 
        
           			$this->expr()->eq('systemtag.visibility', $this->createNamedParameter(true)) 
        
           		)) 
        
           		->groupBy('systemtag.name', 'systemtag.id', 'systemtag.visibility', 'systemtag.editable'); 
        
           	return $this; 
        
           }

@blizzz

I think there is a way, but it should be done async, as this could be expensive 🤔 @blizzz, do you know about this, how performant can this be?

https://github.com/nextcloud/server/blob/master/apps/dav/lib/SystemTag/SystemTagsInUseCollection.php#L82-L107

https://github.com/nextcloud/server/blob/master/lib/private/Files/Cache/CacheQueryBuilder.php#L44-L61

This should be fine to be called (in a non-blocking way). It's also what the Photos app is doing, albeit limited to image mime types. If apps like recognize are used you may end up with a huge number of tags, I doubt if there is a benefit to show more than xty tags.

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

Navigation Menu

Repository navigation

Expandable Tags entry in navigation #18607

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	public function getChildren(): array {
	$user = $this->userSession->getUser();
	$userFolder = null;
	try {
	if ($user) {
	$userFolder = $this->rootFolder->getUserFolder($user->getUID());
	}
	} catch (NoUserException) {
	// will throw a Sabre exception in the next step.
	}
	if ($user === null \|\| $userFolder === null) {
	throw new Forbidden('Permission denied to read this collection');
	}

	$result = $this->systemTagsInFilesDetector->detectAssignedSystemTagsIn($userFolder, $this->mediaType);
	$children = [];
	foreach ($result as $tagData) {
	$tag = new SystemTag((string)$tagData['id'], $tagData['name'], (bool)$tagData['visibility'], (bool)$tagData['editable']);
	// read only, so we can submit the isAdmin parameter as false generally
	$node = new SystemTagNode($tag, $user, false, $this->systemTagManager);
	$node->setNumberOfFiles((int) $tagData['number_files']);
	$node->setReferenceFileId((int) $tagData['ref_file_id']);
	$children[] = $node;
	}
	return $children;
	}

	public function selectTagUsage(): self {
	$this
	->select('systemtag.name', 'systemtag.id', 'systemtag.visibility', 'systemtag.editable')
	->selectAlias($this->createFunction('COUNT(filecache.fileid)'), 'number_files')
	->selectAlias($this->createFunction('MAX(filecache.fileid)'), 'ref_file_id')
	->from('filecache', 'filecache')
	->leftJoin('filecache', 'systemtag_object_mapping', 'systemtagmap', $this->expr()->andX(
	$this->expr()->eq('filecache.fileid', $this->expr()->castColumn('systemtagmap.objectid', IQueryBuilder::PARAM_INT)),
	$this->expr()->eq('systemtagmap.objecttype', $this->createNamedParameter('files'))
	))
	->leftJoin('systemtagmap', 'systemtag', 'systemtag', $this->expr()->andX(
	$this->expr()->eq('systemtag.id', 'systemtagmap.systemtagid'),
	$this->expr()->eq('systemtag.visibility', $this->createNamedParameter(true))
	))
	->groupBy('systemtag.name', 'systemtag.id', 'systemtag.visibility', 'systemtag.editable');

	return $this;
	}

Expandable Tags entry in navigation #18607

Description

Activity

jancborchardt commented on Dec 30, 2019

Andreas-Kainz commented on Dec 30, 2019

jancborchardt commented on Dec 31, 2019

skjnldsv commented on Sep 20, 2023

jancborchardt commented on Sep 21, 2023

skjnldsv commented on Sep 21, 2023

blizzz commented on Sep 22, 2023

nextcloud-command commented on Dec 10, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions