Skip to content

Favorite handling fails for folders not in the filelist #19789

Closed
#39808
Closed
Favorite handling fails for folders not in the filelist#19789
#39808
Labels
1. to developAccepted and waiting to be taken care of26-feedbackbugfeature: file sidebarRelated to the file sidebar component

Description

@nickvergessen
nickvergessen
opened on Mar 5, 2020

Steps to reproduce

  1. Create a folder
  2. Navigate into the folder
  3. Open the sidebar via the share icon in the breadcrumb
  4. Click on the favorite icon

Expected behaviour

Works ⭐

Actual behaviour

Works in the background, but the UI shows an error: Unable to change the favourite state of the file

The problem is OCA.Files.App.fileList.getModelForFile can not find the file and therefor continues with null, causing the following error in the console:

Unable to change favourite state TypeError: "fileInfoModel is null"

cc @skjnldsv

Activity

  1. nickvergessen
    added
    bug
    1. to developAccepted and waiting to be taken care of
    feature: file sidebarRelated to the file sidebar component
    on Mar 5, 2020
  2. nickvergessen
    added this to the Nextcloud 19 milestone on Mar 5, 2020

  3. skjnldsv commented on Mar 5, 2020

    @skjnldsv
    skjnldsv
    on Mar 5, 2020
    Member

    Stupid legacy code :p

  4. nickvergessen commented on Mar 5, 2020

    @nickvergessen
    nickvergessen
    on Mar 5, 2020
    MemberAuthor

    It could also be fixed by reducing the scope of the catch to the actual axios execution

  5. rullzer
    removed this from the Nextcloud 19 milestone on May 7, 2020

  6. szaimen commented on Jan 9, 2023

    @szaimen
    szaimen
    on Jan 9, 2023
    Contributor

    Hi, please update to 24.0.8 or better 25.0.2 and report back if it fixes the issue. Thank you!

  7. szaimen
    added
    needs info
    0. Needs triagePending check for reproducibility or if it fits our roadmap
    and removed
    1. to developAccepted and waiting to be taken care of
    on Jan 9, 2023

  8. nickvergessen commented on Jan 10, 2023

    @nickvergessen
    nickvergessen
    on Jan 10, 2023
    MemberAuthor

    Also on master

  9. nickvergessen
    added
    1. to developAccepted and waiting to be taken care of
    26-feedback
    and removed
    needs info
    0. Needs triagePending check for reproducibility or if it fits our roadmap
    on Jan 10, 2023
  10. skjnldsv
    closed this as completedin #39808on Aug 17, 2023
  11. skjnldsv
    added this to Files to vueon Aug 7, 2024
  12. skjnldsv
    moved this to Done in Files to vueon Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    1. to developAccepted and waiting to be taken care of26-feedbackbugfeature: file sidebarRelated to the file sidebar component

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions