Skip to content

Moving shared folders into and out of each other loses share info #2851

Closed
Closed
Moving shared folders into and out of each other loses share info#2851
Labels
1. to developAccepted and waiting to be taken care ofbugfeature: sharing

Description

@schiessle
schiessle
opened on Dec 23, 2016

While testing a pull request I observed following behavior on master:

  1. user1 shares "folder1" with user2
  2. user2 shares his "folder2" with user3
  3. user2 moves "folder2" into "folder1"
  4. folder2 is still shared with user3 and the "shared from" information changes from user2 to user1 -> perfect!
  5. user2 moves "folder2" out of "folder1"
  6. "folder2" is no longer shared

First I thought this happens because we do a copy&delete which will result in a new file id because the file gets moved across storages. But then we should already lose the share at step 3. Seems that we have some magic to keep the file id and even change the "owner" if a share gets move into another share but not the other way around.

cc @rullzer @icewind1991

Activity

  1. schiessle
    added
    bug
    feature: sharing
    on Dec 23, 2016
  2. nextcloud-bot
    added
    staleTicket or PR with no recent activity
    on Jun 20, 2018
  3. skjnldsv
    added
    0. Needs triagePending check for reproducibility or if it fits our roadmap
    on Jun 12, 2019
  4. ghost removed
    staleTicket or PR with no recent activity
    on Jun 12, 2019

  5. wiswedel commented on Jun 12, 2019

    @wiswedel
    wiswedel
    on Jun 12, 2019
    Contributor

    I could just reproduce the issue on 16.0.1

  6. wiswedel
    added
    1. to developAccepted and waiting to be taken care of
    and removed
    0. Needs triagePending check for reproducibility or if it fits our roadmap
    on Jun 12, 2019

  7. Klakla2 commented on Nov 9, 2019

    @Klakla2
    Klakla2
    on Nov 9, 2019

    Reproduced on 16.0.6 .

  8. Klakla2 commented on Nov 11, 2019

    @Klakla2
    Klakla2
    on Nov 11, 2019

    Is there a workaround for this?

  9. PVince81 commented on Nov 11, 2021

    @PVince81
    PVince81
    on Nov 11, 2021
    Member

    still happening in NC 22.2.0.

  10. PVince81
    changed the title [-]Moving shared folders[/-] [+]Moving shared folders into and out of each other loses share info[/+] on Nov 11, 2021

  11. PVince81 commented on Nov 3, 2022

    @PVince81
    PVince81
    on Nov 3, 2022
    Member

    should be fixed already through #30791

  12. PVince81
    closed this as completedon Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    1. to developAccepted and waiting to be taken care ofbugfeature: sharing

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions