Repository navigation
[BITV] Header bar a11y issues #33741
Description
Need to recheck those for #33728 @juliushaertl @CarlSchwan
- [BITV] Focused item overlaps neighbor elements with text and border #35201
- Header navigation needs to be a
<nav>landmark - Logo link should not be h1, but rather have aria-label="to Nextcloud landing page"
- h1 should instead be in the app content, ideally displayed visually #35138
- active app needs to be tagged as aria-current="page"
- "More" menu icon needs to be a
<button>, not a link - When the menu is not focused anymore, it should be closed
- On mobile, active app needs better indication (e.g. via a dot)
Activity
juliusknorr commentedon Aug 30, 2022
Checked everything that is addressed in the above PR.
I've been talking with @jancborchardt about this already, but we don't have a good idea how to solve that nicely yet.
I'll keep this separate from the app menu pr to get it in more quickly for the UI redesign.
app content however might not be suitable as it is replaced by any vue app, if we need it in the content, we need some concept how that would look for the individual apps first @jancborchardt
JuliaKirschenheuter commentedon Nov 11, 2022
Already done in #35071
aria-label is't needed because
<img>hasaltJuliaKirschenheuter commentedon Nov 15, 2022
jancborchardt commentedon Nov 15, 2022
PVince81 commentedon Nov 17, 2022
closing as most are done
we continue to track the last task in #35201
Add styles for #33741. Remove boards and add underlines.
Merge pull request #35545 from nextcloud/enh/enh-fix-styles-for-33741…