[Bug]: NC25 not working with disabled Theming app #34338

Activity

1. Rello

   added

   bug

   0. Needs triagePending check for reproducibility or if it fits our roadmapPending check for reproducibility or if it fits our roadmap

   on Sep 30, 2022
2. szaimen

   added

   high

   25-feedback

   on Sep 30, 2022
3. genma commented on Oct 5, 2022

   

   genma

   on Oct 5, 2022

   More actions

   I've the same issuses a written a blog post in French with some screenshot https://blog.genma.fr/?Nextcloud-25-l-application-theming-casse-l-affichage-des-CSS

   👍React with 👍1Reacted by Jérôme Herbinet
4. AndyScherzinger

   added this to the Nextcloud 25 milestone on Oct 6, 2022
5. AndyScherzinger commented on Oct 6, 2022

   

   AndyScherzinger

   on Oct 6, 2022

   Member

   More actions

   Looping in @PVince81 and @juliushaertl
6. PVince81 commented on Oct 10, 2022

   

   PVince81

   on Oct 10, 2022

   Member

   More actions

   and @Pytal
7. Pytal commented on Oct 12, 2022

   

   Pytal

   on Oct 12, 2022

   Member

   More actions

   Some dashboard js depends on theming to adjust the header

   Tracking in #33969
8. nickvergessen commented on Oct 14, 2022

   

   nickvergessen

   on Oct 14, 2022

   Member

   More actions

   Since the theming app now also hosts the accessibility settings, should we force enable it?
   Feels weird that an admin can decide to punish people for their accessibility lacks by disabling an app they just don't need themselves?

   👍React with 👍3Reacted by Simon L., Gerrit and Carl Schwan
9. szaimen

   added

   2. developingWork in progressWork in progress

   and removed

   0. Needs triagePending check for reproducibility or if it fits our roadmapPending check for reproducibility or if it fits our roadmap

   on Oct 14, 2022
10. szaimen commented on Oct 14, 2022

    

    szaimen

    on Oct 14, 2022

    Contributor

    More actions

    WIP here: #34609 however I didn't test yet what happens if you disable the app and upgrade to this branch.
11. blizzz

    closed this as completedin #34609on Oct 18, 2022
12. kyrofa commented on Apr 30, 2023

    

    kyrofa

    on Apr 30, 2023

    Member

    More actions

    Hey @szaimen, the theming app is disabled by default in the snap because it adds warnings about not having imagick. Did you ever test updates when this app is disabled? Any bad side effects? Has anyone considered splitting critical functionality out of a non-critical theming app so folks who don't want imagick installed don't constantly see a warning?
13. nickvergessen commented on Apr 30, 2023

    

    nickvergessen

    on Apr 30, 2023

    Member

    More actions

    it's not a warning as it's not yellow and not an error as it's not red. It's an info.
    The problem is when there are no errors/warnings the headlines still say "Setup warnings", so that's why you might confuse it for that.

    Also note, since Nextcloud 25 the Theming app is one of the apps that must always be enabled:
    https://github.com/nextcloud/server/blob/stable25/core/shipped.json#L100
    https://github.com/nextcloud/server/blob/stable26/core/shipped.json#L100
    https://github.com/nextcloud/server/blob/master/core/shipped.json#L100

    The reason is it was merged with the accessibility features as they shared to many settings and technics and need to work hand-in-hand, but Accessibility is not optional, it's one of the core principals of the Nextcloud project, see https://nextcloud.com/about/ (middle of the page, seems to miss anchors at the moment).
    So please remove any code that would try to disable/remove/prevent theming.

    👍React with 👍2Reacted by Josh and Pascal

    ❤️React with ❤️1Reacted by Simon L.
14. kyrofa commented on May 1, 2023

    

    kyrofa

    on May 1, 2023

    Last edited by kyrofa

    Member

    More actions

    it's not a warning as it's not yellow and not an error as it's not red. It's an info.
    The problem is when there are no errors/warnings the headlines still say "Setup warnings", so that's why you might confuse it for that.

    That's a bit pedantic. The people who log bugs about that don't see it that way. Fixing that messaging would be helpful.

    So please remove any code that would try to disable/remove/prevent theming.

    That's just signing us up for triaging more invalid bug reports. Can we please consider moving accessibility to another trimmed down app specifically for it?
15. szaimen commented on May 1, 2023

    

    szaimen

    on May 1, 2023

    Contributor

    More actions

    I think the best way forward would be this: #36607
16. tonyguepin commented on Jul 1, 2023

    

    tonyguepin

    on Jul 1, 2023

    More actions

    Due to the theming app being forcibly enabled, as of 25,
    we're running into problems when using our own customized theme which required the theming app to be disabled.
    Our customized theme redefines some css-vars and styles , these are now being overwritten by the theming app.

    Do I understand correctly that the reason for the forcibly enabled theming app is the need for "accessibility features" ?
17. gioman commented on Jul 29, 2023

    

    gioman

    on Jul 29, 2023

    More actions

    Due to the theming app being forcibly enabled, as of 25, we're running into problems when using our own customized theme which required the theming app to be disabled. Our customized theme redefines some css-vars and styles , these are now being overwritten by the theming app.

    Do I understand correctly that the reason for the forcibly enabled theming app is the need for "accessibility features" ?

    @tonyguepin similar situation here. I was trying to use just one instance of NC 27 for multiple domain names, and depending on the domain show a different theme. I spent quite a lot in reading posts and docs, and it seemed feasible as some of the configs worked, while others not

    i.e.
    https://help.nextcloud.com/t/howto-individual-themes-per-domain/27585

    the part that isn't working is the override/injection of some CSS property, as described in this legacy page of the docs

    https://docs.nextcloud.com/server/12/developer_manual/core/theming.html

    and finally/sadly read this post

    https://help.nextcloud.com/t/howto-individual-themes-per-domain/27585/24

    So I kindly ask: now that is not possible to disable theming, how to override/inject CSS properties into custom themes ("themes" folder, using the "example" theme/folder as template for others) now that functions in defaults.php like

    public function getScssVariables() {
        return [
            'color-primary' => '#745bca'
        ];
    }
    

    are ignored or simply overridden by the theming functionality?

    Thanks in advance