Skip to content

Upload/add button style and discoverability #37207

Closed
#39884
Closed
Upload/add button style and discoverability#37207
#39884
Assignees
szaimen
Labels
1. to developAccepted and waiting to be taken care ofdesignDesign, UI, UX, etc.enhancement
Milestone
Nextcloud 27.1.0

Description

@jancborchardt
jancborchardt
opened on Mar 14, 2023

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
The upload button in Files is not super present, and looks old compared to our other buttons.

Describe the solution you'd like
We should upgrade it to the secondary NcButton from the components. And a simple text "Add" next to the "+" in the upload button would be good.

Additional context
Current:
image

Proposed:
image

Activity

  1. jancborchardt
    added
    enhancement
    designDesign, UI, UX, etc.
    1. to developAccepted and waiting to be taken care of
    on Mar 14, 2023
  2. jancborchardt
    modified the milestones: Nextcloud 26, Nextcloud 27 on Mar 14, 2023

  3. ishaan730 commented on Apr 26, 2023

    @ishaan730
    ishaan730
    on Apr 26, 2023 · Hidden as off-topic

  4. jancborchardt commented on Apr 26, 2023

    @jancborchardt
    jancborchardt
    on Apr 26, 2023 · Hidden as off-topic
    Author

  5. ishaan730 commented on Apr 27, 2023

    @ishaan730
    ishaan730
    on Apr 27, 2023 · Hidden as off-topic

  6. lhsazevedo commented on Apr 30, 2023

    @lhsazevedo
    lhsazevedo
    on Apr 30, 2023
    Contributor

    Hi! Would be a reasonable approach to proceed with the original task and move @ishaan730's great proposal to a new issue?
    That way we can improve the product for users right away, while the proposal is matured and discussed with the attention it deserves.

    EDIT:
    @jancborchardt I see that this part of the files app wasn't fully migrated to Vue just yet. Should we wait for it?

  7. jancborchardt commented on Jun 7, 2023

    @jancborchardt
    jancborchardt
    on Jun 7, 2023
    MemberAuthor

    @lhsazevedo yes, absolutely the original proposal still stands and makes sense as it is a very small but nice improvement. If you like, feel free to submit a pull request for it. :)

  8. jancborchardt
    added this to 🖍 Design teamon Jun 7, 2023
  9. jancborchardt
    moved this to 🏗️ At engineering in 🖍 Design teamon Jun 7, 2023
  10. jancborchardt
    moved this from 🏗️ At engineering to 📐 Design phase in 🖍 Design teamon Jun 7, 2023
  11. skjnldsv
    removed this from the Nextcloud 27 milestone on Jun 9, 2023

  12. 1 remaining item

  13. jancborchardt
    moved this from 📐 Design phase to 🏗️ At engineering in 🖍 Design teamon Jul 14, 2023
  14. szaimen
    self-assigned this
    on Jul 17, 2023
  15. AndyScherzinger
    modified the milestones: Nextcloud 27.0.1, Nextcloud 27.0.2 on Jul 17, 2023
  16. AndyScherzinger
    modified the milestones: Nextcloud 27.0.2, Nextcloud 27.1.0 on Aug 3, 2023

  17. jancborchardt commented on Aug 14, 2023

    @jancborchardt
    jancborchardt
    on Aug 14, 2023
    MemberAuthor

    @szaimen would be nice to have this in both Files and the new filepicker by @susnux for 27.1.0. :)

  18. AndyScherzinger
    added
    🍁 2023-Autumn
    on Aug 15, 2023

  19. susnux commented on Aug 15, 2023

    @susnux
    susnux
    on Aug 15, 2023
    Contributor

    Filepicker PR: nextcloud-libraries/nextcloud-dialogs#892

  20. jancborchardt
    moved this from 🏗️ At engineering to 🕶️ Design review in 🖍 Design teamon Aug 16, 2023
  21. szaimen
    closed this as completedin #39884on Aug 16, 2023
  22. github-project-automation
    moved this from 🕶️ Design review to 🎉 Done in 🖍 Design teamon Aug 16, 2023

  23. theosche commented on Sep 18, 2023

    @theosche
    theosche
    on Sep 18, 2023

    Looks good on Safari 16.5.1:
    Capture d’écran 2023-09-18 à 22 23 50
    But not that good on Firefox 116.0.2:
    Capture d’écran 2023-09-18 à 22 23 33
    [Nextcloud 27.1.0]
    Should I open another issue ?

  24. szaimen commented on Sep 18, 2023

    @szaimen
    szaimen
    on Sep 18, 2023
    Contributor

    You need to clear the browser cache...

  25. theosche commented on Sep 18, 2023

    @theosche
    theosche
    on Sep 18, 2023

    You need to clear the browser cache...

    Thanks it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

1. to developAccepted and waiting to be taken care ofdesignDesign, UI, UX, etc.enhancement

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions