Skip to content

Simplify sharing permissions for folders #8479

Closed

Description

@jancborchardt

We currently have:

  • Can reshare
  • Can add
  • Can edit
  • Can delete

Now "can delete" does not really make much sense. If you can edit, you can delete all content of a file.

"Can add": We added this cause we originally had CRUD permissions, but do we really need it / do people use it? Usually you can either edit or not.

Activity

  1. MorrisJobke commented on Feb 21, 2018

    @MorrisJobke
    Member

    "Can add": We added this cause we originally had CRUD permissions, but do we really need it / do people use it? Usually you can either edit or not.

    I think "can add" is used for the files drop stuff, isn't it? cc @nextcloud/sharing

  2. rullzer commented on Feb 27, 2018

    @rullzer
    Member

    Yes it is. But as long as wel keep the files drop as a separte option users don't have to care ;)

  3. MorrisJobke commented on Feb 27, 2018

    @MorrisJobke
    Member

    I still think that we can slim it down to:

    • for internal/federated/circle shares:
    • can edit
    • can reshare
    • for public links
    • can edit
    • files drop (can add without listing files)
  4. MorrisJobke commented on Mar 8, 2018

    @MorrisJobke
  5. MorrisJobke commented on Jun 26, 2018

    @MorrisJobke
  6. jancborchardt commented on Jun 27, 2018

    @jancborchardt
    Author
  7. MorrisJobke commented on Jul 16, 2018

    @MorrisJobke
  8. skjnldsv commented on Oct 30, 2019

    @skjnldsv
  9. 4 remaining items

  10. trommegutten commented on May 23, 2020

    @trommegutten

    I don't like accidents like this #6620 (comment)

    @pixelipo got some thumbs up for this suggestion:

    What about simply having 3 independent (checkbox) items:
    view (read)
    upload
    edit/delete

    #6620 (comment)

    That could be a nice way to do it, what do You think?

  11. marvinjuette commented on Sep 19, 2020

    @marvinjuette

    Hey, I am facing the same problem. And if I am correct the problem is only a front-end one because as others already pointed out one can simply change the permission to 5 in the database.

    Linkt to post that shows working solution

    So basically it should be easy to "add" (display) this option.

    But the question is how we want to display that option?

    Should it be a checkbox "disable delete" or just another radio button like "upload + read only"?

  12. Mannshoch commented on Oct 13, 2020

    @Mannshoch

    I don't like accidents like this #6620 (comment)

    @pixelipo got some thumbs up for this suggestion:

    What about simply having 3 independent (checkbox) items:
    view (read)
    upload
    edit/delete

    #6620 (comment)

    That could be a nice way to do it, what do You think?

    I personally vote for #10012

  13. marvinjuette commented on Oct 13, 2020

    @marvinjuette

    I like the options you get offered when sharing internally. Why don't use them for public link sharing?

  14. pred2k commented on Jan 31, 2021

    @pred2k

    I think is this THE use case for a file exchange tool like nextcloud.
    We have an event and attendees want to share photo or something else. They probably dont want/need an account. Host dont have all their email addreses.
    They can easily upload items via webui, but are not allowed to to delete everything.

    Please offer public link sharing setting "upload + read only"!

  15. kaiserls commented on Jul 10, 2021

    @kaiserls

    Dear everyone,
    I would like to point out that this issue is linked to many issues which seem to be important to the nextcloud community and some of them are nearly 3 or even 4 years old (#6620, #8479). Couldn't the "upload + read only" feature get decoupled from the complete overhaul of the sharing gui and therefore be quickly published?

  16. kaiserls commented on Aug 30, 2021

    @kaiserls

    Is this: #28635 the rework of the sharing permissions #26691 and completely ignoring issue #6620 and all the duplicates? Or am I wrong? Sry if this is the case.

  17. kongomongo commented on Feb 10, 2022

    @kongomongo

    I have skimmed through many of those issues like @kaiserls wrote, but I have yet to see any objection to the "upload and not delete" and/or finer-grain control of the https://github.com/nextcloud/server/blob/master/lib/public/Constants.php permissions.

    What is the root cause for no progress?

  18. skjnldsv commented on Jan 19, 2024

    @skjnldsv
    Member
  19. sweenu commented on Jan 19, 2024

    @sweenu

    If you close this issue, please re-open #6620 because it was closed as duplicate of this issue even though it definitely does not seem to be fixed: we still don't have a way to have File Upload + Read on a folder.

  20. skjnldsv commented on Jan 20, 2024

    @skjnldsv
    Member

    we still don't have a way to have File Upload + Read on a folder.

    Hmm, yes you can? (NC 27 and 28) :)
    image

  21. sweenu commented on Jan 20, 2024

    @sweenu

    Oh great news! I had tried on the android app, assuming permissions would be the same on every platforms. But indeed, I should have tried on the web before commenting 👍🏽 Great job.

  22. added
    4. to releaseReady to be released and/or waiting for tests to finish
    and removed
    1. to developAccepted and waiting to be taken care of
    on Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions