Repository navigation
Add Quick-Access to favorite folder in left sidepanel in files-app #9714
Description
It would be a good feature to add a quick way to access favorite folders on the "main" view of the file app. Most Fileexplorer have such a feature to access often used directories quickly.
I have already started implementing this in the files-app, i am creating this Issue mostly to gather feedback and to check if the files-app is the right place to implement this (in opposition to an additional app wich extends the original app ( I dont know how to do this)).
This feature is going to be toggleable.
Activity
c0fe commentedon Jun 1, 2018
This looks like a pretty useful feature to be honest.
@MorrisJobke @rullzer any thoughts?
MorrisJobke commentedon Jun 2, 2018
Cc @nextcloud/designers
enoch85 commentedon Jun 2, 2018
👍
newhinton commentedon Jun 2, 2018
I have added a pull request.
The only thing which does not properly work, is the initial State of the checkbox which enables this functionality. It is properly set, but the initial state is always unchecked, regardless of the true value.
newhinton commentedon Jun 3, 2018
The trashbin and quota-indicator are list-elements which are pushed down to "dock" on the settings button. If the folderlist exceeds the size of the sidebar, it gets a scrollbar, which is fine.
The problem: Quota and Trashbin are listelements and therefore they are pushed "under" the settingsbutton. Should they stay over that button, or is it acceptable to let them slide down?
skjnldsv commentedon Jun 3, 2018
@newhinton no, it is the expected behaviour :)
This is intended for better accessibility on small height views which reduced the total height and show too few of the first navigations items.
[-][Feature] Add Quick-Access to favorite folder in left sidepanel in files-app[/-][+]Add Quick-Access to favorite folder in left sidepanel in files-app[/+]juliusknorr commentedon Jun 4, 2018
While I like the idea of having favorite folders directly accessible, I fear that this will clutter the UI too much once you have more folders marked as favorite. Maybe we could just limit it to first level favorite folders or have a hard limit of 3-4 entries? Anyhow having a limit would only make sense if we could show the most recently used folders or something similar.
cc @jancborchardt
skjnldsv commentedon Jun 4, 2018
We also supports collapsible entries, we could go for this?
newhinton commentedon Jun 4, 2018
A stylechange could help differentiate between menu-entries and favorites. Making favorites smaller could clean up the UI, but I'll need to try that out and see if it works
c0fe commentedon Jun 4, 2018
@juliushaertl what about making this into an accordion style menu where if you click you will get the full list? or perhaps show a number of items then a button "show more"?
newhinton commentedon Jun 4, 2018
Also, this is not enabled by default, so the user needs to actively decide to "clutter" his UI, so it would be an active decision by the user
skjnldsv commentedon Jun 4, 2018
Yeah, in the end, maybe it's not that big of a deal! :)
27 remaining items
Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720
newhinton commentedon Jul 20, 2018
@skjnldsv Can i close this issue, and if yes, how do you handle successful issue-closing? Is there a tag to mark it as successfully closed other than the label '4. to release' ? Or should we do it after the merge of #10320?
newhinton commentedon Jul 20, 2018
@skjnldsv Oh, and i have seen that the star-icon was removed for the Navbarelement, what was the design desicion behind that? To me it looks a little bit strange that there is only blank space, it seems so empty :) (Same for Shares)
skjnldsv commentedon Jul 21, 2018
@newhinton, no descision, just an error, we'll add it back :)
Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720
Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720
Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720
Merge pull request #10320 from nextcloud/feature/10176/Quick-Access-C…
Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720