Repository navigation
Show thumbnail on rename - #12467
Merged
Merged
Show thumbnail on rename#12467
Conversation
* does not hide thumbnail when rename is shown * fixes layout for grid and list view * fixes #11901 Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
requested review from
ChristophWurst,
jancborchardt,
juliusknorr,
kesselb,
rullzer and
skjnldsv
November 15, 2018 11:20
JanDragon
approved these changes
Nov 15, 2018
Signed-off-by: Morris Jobke <[email protected]>
rullzer
approved these changes
Nov 15, 2018
rullzer
left a comment
rullzer
left a comment
Member
There was a problem hiding this comment.
Seem to do the trick! Quick smoke tests shows it works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Hovered:
@nextcloud/designers Have a look. I know it involves a lot of CSS fiddling, but I don't want to completely reorder the DOM structure as of now.