Repository navigation
Make read/write options in sharing view radiobuttons - #4681
Merged
Merged
Conversation
Implement the suggestions from #2207 Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Felix A. Epp <[email protected]>
Signed-off-by: Felix A. Epp <[email protected]>
eppfel
added
2. developing
eppfel
requested review from
LukasReschke,
MorrisJobke,
jancborchardt,
rullzer and
schiessle
May 3, 2017 23:45
|
@eppfel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @blizzz and @MorrisJobke to be potential reviewers. |
Member
|
You 🎸! I'll see if I can make it do stuff again. |
Signed-off-by: Roeland Jago Douma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4681 +/- ##
============================================
- Coverage 31.35% 31.35% -0.01%
Complexity 22097 22097
============================================
Files 1361 1361
Lines 84106 84104 -2
Branches 1324 1322 -2
============================================
- Hits 26374 26373 -1
+ Misses 57732 57731 -1
|
Member
|
Seems to work now! |
rullzer
added
3. to review
rullzer
approved these changes
May 4, 2017
Member
|
Good stuff, thank you so much @eppfel! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to PR #3784 to make the files_drop sharing feature more prominent as proposed in #2207 .
I added the
radioclass to the radiobuttons for styling and fixed a small typo.Tested on macOS 10.11.6 in Chrome, Firefox and Safari
Sadly it does not seem to work anymore, because the radio buttons have no effect. Maybe due to rebasing...
@rullzer Care to have a look?