You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think a discussion needs to be had first as the wording was seemingly chosen for a reason, but I'd hope for a little more logic than just a wording change as outlined in the context thread on help.nc:
@jancborchardt We talked exactly about this during the hackweek ;)
It's mentioned in the review of 11 as "Think about 'hide file listing'" - see #2134
@nextcloud/designers Any ideas how to make this more discoverable? Maybe also show this by default (when "Allow edit" is not ticked but then show it disabled?)
@MorrisJobke might've been from my original post, as that was June 😄
I made this suggestion:
Where clicking allow edit greys out the file drop option, similarly the opposite happens when file drop is clicked.
and.. err.. this one too, but I make a lot of drop folders for media uploads after gigs, so I'm not sure how often the "normal" userbase would use this:
@jasonbayton that seems good! I’d go first with the rewording in the share menu. Adding it to the »New« menu is a bit too much since the Collabora stuff is also in there.
I'm game for radio buttons. But there'd need to be a read-only radio option too, since that's what shares are by default (and radio always defaults to one option)
Activity
tflidd commentedon Nov 20, 2016
If you only want to change the wording, the string can be found here:
server/core/js/sharedialoglinkshareview.js
Line 340 in 7100a1b
(you can clone the nextcloud-server-repo, create a new branch, make and submit the changes and then create a pull request).
jasonbayton commentedon Nov 20, 2016
I think a discussion needs to be had first as the wording was seemingly chosen for a reason, but I'd hope for a little more logic than just a wording change as outlined in the context thread on help.nc:
https://help.nextcloud.com/t/filedrop-can-it-be-a-little-more-obvious/659/5?u=jasonbayton
MorrisJobke commentedon Nov 21, 2016
@jancborchardt We talked exactly about this during the hackweek ;)
It's mentioned in the review of 11 as "Think about 'hide file listing'" - see #2134
@nextcloud/designers Any ideas how to make this more discoverable? Maybe also show this by default (when "Allow edit" is not ticked but then show it disabled?)
jasonbayton commentedon Nov 21, 2016
@MorrisJobke might've been from my original post, as that was June 😄
I made this suggestion:

Where clicking allow edit greys out the file drop option, similarly the opposite happens when file drop is clicked.
and.. err.. this one too, but I make a lot of drop folders for media uploads after gigs, so I'm not sure how often the "normal" userbase would use this:
jancborchardt commentedon Nov 21, 2016
@jasonbayton that seems good! I’d go first with the rewording in the share menu. Adding it to the »New« menu is a bit too much since the Collabora stuff is also in there.
@nextcloud/javascript what do you think?
fix wording of File drop, ref #2207
jancborchardt commentedon Nov 22, 2016
There’s a pull request for the wording at #2243
In addition, and what I also mentioned there, instead of the greying out which would be a bit confusing I propose:
This is probably something for Nextcloud 12 though because of the feature freeze.
jasonbayton commentedon Nov 22, 2016
I'm game for radio buttons. But there'd need to be a read-only radio option too, since that's what shares are by default (and radio always defaults to one option)
jancborchardt commentedon Nov 24, 2016
Right, also as you mentioned in the pull request. We need to go for a 3-option radio button. :)
jasonbayton commentedon Nov 24, 2016
I'm not a big GH user, I may have accidentally commented on the PR and then realised it should be here!
5 remaining items
Make files drop more permanent
Make files drop more permanent
MorrisJobke commentedon Apr 30, 2017
@jancborchardt We awaited some help here from you but the PR was closed in the meantime, because of inactivity: #3784
jasonbayton commentedon Apr 30, 2017
Don't leave us hanging @jancborchardt!
Espina2 commentedon May 3, 2017
I think @eppfel open a pull request with the same improvoment but based on this, #4273
jasonbayton commentedon May 3, 2017
So I don't see the changes in 12 beta for a radio button arrangement. Is it going to make the final?
MorrisJobke commentedon May 3, 2017
It wasn't finished in time.
jasonbayton commentedon May 3, 2017
Bummer. Bring on 12.1! 🤣
MorrisJobke commentedon May 3, 2017
I guess we will have no 12.1 ... the next one will be 13. 🤔
Make files drop more permanent
MorrisJobke commentedon May 4, 2017
Fix for this is in #4681
MorrisJobke commentedon May 4, 2017
Merged