Skip to content

Missing array assignment in Swift.php - #6101

Merged
LukasReschke merged 1 commit into
nextcloud:masterfrom
cbartz:patch-1
Aug 15, 2017
Merged

Missing array assignment in Swift.php#6101
LukasReschke merged 1 commit into
nextcloud:masterfrom
cbartz:patch-1

Conversation

@cbartz

@cbartz cbartz commented Aug 14, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

The array is referenced with the tmpfile index in the callback function.

Fix #6019 .

@icewind1991

icewind1991 commented Aug 14, 2017

Copy link
Copy Markdown
Member

Thanks for you contribution!

The $tmpFiles array should no longer be needed since the $path is no passed to the writeBack callback, you can adjust the $this->objectCache->remove call to use the $path that is passed and get rid of the $tmpFiles array altogether.

Christopher Bartz
Remove tmpFiles Array in Swift.php
bbd8797 
tmpFiles Array is unnecessary and there has been
a reference without an assignment which lead to a bug making swift external
storage unuseable.
@codecov

codecov Bot commented Aug 14, 2017

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@5b2d6b0). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #6101   +/-   ##
=========================================
  Coverage          ?   53.12%           
  Complexity        ?    22803           
=========================================
  Files             ?     1407           
  Lines             ?    88240           
  Branches          ?     1327           
=========================================
  Hits              ?    46880           
  Misses            ?    41360           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/Lib/Storage/Swift.php 0% <0%> (ø) 113 <0> (?)

@LukasReschke
LukasReschke merged commit f698aa1 into nextcloud:master Aug 15, 2017
@mirtouf mirtouf mentioned this pull request Sep 3, 2017
Closed
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Sep 3, 2017
@MorrisJobke

MorrisJobke commented Sep 3, 2017

Copy link
Copy Markdown
Member

@icewind1991 I guess it makes sense to backport this to stable12, right? (see #5882)

@icewind1991 icewind1991 mentioned this pull request Sep 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasReschke LukasReschke LukasReschke approved these changes
@icewind1991 icewind1991 icewind1991 approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: external storage

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

4 participants

@cbartz @icewind1991 @MorrisJobke @LukasReschke