Skip to content

Sort files in dialog by name. - #9151

Merged
MorrisJobke merged 1 commit into
nextcloud:masterfrom
panovotn:dialog-sort
May 7, 2018
Merged

MorrisJobke merged 1 commit into
nextcloud:masterfrom
panovotn:dialog-sort

Conversation

@panovotn

@panovotn panovotn commented Apr 11, 2018 •

Copy link
Copy Markdown
Contributor

Sort file picker dialog entries alphanumerically. #9011

Signed-off-by: Patrik Novotný [email protected]

@codecov

codecov Bot commented Apr 11, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #9151 into master will increase coverage by 0.04%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #9151      +/-   ##
============================================
+ Coverage      51.9%   51.95%   +0.04%     
- Complexity    25361    25402      +41     
============================================
  Files          1606     1605       -1     
  Lines         95314    95360      +46     
  Branches       1394     1394              
============================================
+ Hits          49477    49540      +63     
+ Misses        45837    45820      -17
Impacted Files Coverage Δ Complexity Δ
core/js/oc-dialogs.js 0.43% <0%> (ø) 0 <0> (ø) ⬇️
apps/dav/lib/Connector/Sabre/File.php 60.24% <0%> (-12.96%) 148% <0%> (+45%)
lib/private/Mail/Message.php 79.16% <0%> (-6.36%) 25% <0%> (-4%)
...B/QueryBuilder/FunctionBuilder/FunctionBuilder.php 71.42% <0%> (-6.35%) 7% <0%> (-2%)
lib/private/legacy/app.php 58.87% <0%> (-3.77%) 195% <0%> (-1%)
lib/private/Avatar.php 75.49% <0%> (-3.46%) 54% <0%> (+10%)
lib/private/Mail/Mailer.php 60.91% <0%> (-0.45%) 28% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.46% <0%> (-0.25%) 136% <0%> (ø)
core/templates/untrustedDomain.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
settings/routes.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 12 more

@MorrisJobke

Copy link
Copy Markdown
Member

A different sorting was merged with #8820 - @nextcloud/designers which way do we want to go? Name or modified date.

@MorrisJobke MorrisJobke added enhancement 3. to review Waiting for reviews labels Apr 12, 2018
@tomtomas99911

Copy link
Copy Markdown

Please take into consideration that sorting by name is much better option for huge amount of directories. In enterprise use case is not good idea to sort folders by mtime. When you have thousand of folders you need to alphanumerical sorting.

@MorrisJobke

Copy link
Copy Markdown
Member

Please take into consideration that sorting by name is much better option for huge amount of directories. In enterprise use case is not good idea to sort folders by mtime. When you have thousand of folders you need to alphanumerical sorting.

Makes sense IMO

@juliusknorr

Copy link
Copy Markdown
Member

Just as in the regular file list we should have the option to sort by both though clicking the table headers. As this is obviously a bigger change, I'd say we should use the sort by name for now. @UncleAlbie Can you rebase your branch on current master?

Signed-off-by: Patrik Novotný <[email protected]>
@panovotn

Copy link
Copy Markdown
Contributor Author

@juliushaertl Branch rebased on current master.

@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Apr 18, 2018

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now this makes sense and we should look into refine this by clicking the header in a separate PR.

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 7, 2018
@MorrisJobke
MorrisJobke merged commit 43c1e51 into nextcloud:master May 7, 2018
@panovotn
panovotn deleted the dialog-sort branch May 10, 2018 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants