Repository navigation
Sort files in dialog by name. - #9151
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9151 +/- ##
============================================
+ Coverage 51.9% 51.95% +0.04%
- Complexity 25361 25402 +41
============================================
Files 1606 1605 -1
Lines 95314 95360 +46
Branches 1394 1394
============================================
+ Hits 49477 49540 +63
+ Misses 45837 45820 -17
|
|
A different sorting was merged with #8820 - @nextcloud/designers which way do we want to go? Name or modified date. |
|
Please take into consideration that sorting by name is much better option for huge amount of directories. In enterprise use case is not good idea to sort folders by mtime. When you have thousand of folders you need to alphanumerical sorting. |
Makes sense IMO |
|
Just as in the regular file list we should have the option to sort by both though clicking the table headers. As this is obviously a bigger change, I'd say we should use the sort by name for now. @UncleAlbie Can you rebase your branch on current master? |
Signed-off-by: Patrik Novotný <[email protected]>
|
@juliushaertl Branch rebased on current master. |
MorrisJobke
left a comment
There was a problem hiding this comment.
For now this makes sense and we should look into refine this by clicking the header in a separate PR.
Sort file picker dialog entries alphanumerically. #9011
Signed-off-by: Patrik Novotný [email protected]