Repository navigation
Unified header #82
Description
Activity
cc @skjnldsv as well regarding the Viewer app ^
- removed this from the milestone
on Jan 16, 2020 11 remaining items
@juliushaertl I have some technical questions:
- How can I get
shared byand download link from the text app since they exist in server app? How can we pass those values to text app? - How can we trigger the event to open the sidebar from the text app?
- How can I get
I'm wondering if we should actually rebuild the already existing UI or the option I would prefer is to find a way to inject the menubar and the avatars into the existing header.
Not yet sure if that is technically feasible but maybe we could somehow trick the component to render into divs outside of the main text container.
@vinicius73 Maybe you have a creative idea or can tell if that is a stupid idea :D
One potential library for that I've found would be https://portal-vue.linusb.org
Reacted by Luka Trovic@juliushaertl I did some research based on your suggestion:
First, we need to put a portal target on our header.
And then we need to wrap the menubar into the<Portal>component. That means we need to modify thenexcloud-vuelibrary.
We need to modify both thetextapp and thenexcloud-vue.
Since thenextcloud-vueis a library, I don't think we can modify it and it seems not feasible...As just discussed in the call, I think we may dynamically insert an element to the div.header-left and then render the portal target into it similar to LinusBorg/portal-vue#114 (comment)
Reacted by Luka Trovic- moved this from 📄 To do (5-20 entries) to 🏗️ In progress in 📝 Productivity team
on Jul 20, 2022 - moved this from 🛑 On hold to 🧭 Planning evaluation (don't pick) in 📝 Productivity team
on Jun 29, 2023
Here are the mockups:
Unified bar Viewer + Text when logged in
We should also combine the Share icon and the avatars into one overlapped thing. When we have avatars, we don’t need a share icon at all, and they don’t need individual clickable area – all can open the sidebar.
For Shared links, even put the controls in the blue header bar
Desktop
Mobile
Smaller polishing before the rename (already done):