Repository navigation
Create Signaling script (#1) - #1317
Merged
Merged
Conversation
initial support for signaling server Signed-off-by: morph027 <[email protected]>
Signed-off-by: morph027 <[email protected]>
enoch85
reviewed
Jul 11, 2020
morph027
commented
Jul 12, 2020
@morph027 I don't know if everything is needed, and I didn't test, but at least the logic is there now. What I'm thinking is another subdomain to handle Talk Signaling, but I might be wrong?
Member
|
Hey @morph027 Do you think we can book a session to fix this PR when we both are online? |
Member
|
@szaimen You're also welcome to work on this. 😄 |
Collaborator
Author
|
Huh, sorry, was quite busy. I'll have some spare time for coding in 2 weeks time. Until then, i'm available for anything else (review, hints, ...). |
@morph027 I would really like to make some progress here, and you're the expert. :)
Member
|
@morph027 OK, let's book a "hackathon" in 2 weeks then. I'll send you an invite. We can use Talk (hehe) for chatting. |
This comment has been minimized.
This comment has been minimized.
enoch85
marked this pull request as ready for review
August 24, 2020 18:32
szaimen
reviewed
Aug 24, 2020
szaimen
reviewed
Aug 24, 2020
szaimen
reviewed
Aug 24, 2020
| # shellcheck disable=2034,2059 | ||
| true | ||
| # shellcheck source=lib.sh | ||
| NC_UPDATE=1 && TURN_INSTALL=1 . <(curl -sL https://raw.githubusercontent.com/nextcloud/vm/master/lib.sh) |
Collaborator
There was a problem hiding this comment.
BTW: I don't like it that you have to enter the domain at the very beginning of the script... maybe we can do it like in onlyoffice-docker?
Member
There was a problem hiding this comment.
@szaimen Could you please add this change to the new PR?
szaimen
reviewed
Aug 24, 2020
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial support for signaling server, shoud fix #1317