docs clarification #1080

Activity

1. gireeshpunathil commented on Jan 26, 2018

   

   gireeshpunathil

   on Jan 26, 2018

   Member

   More actions

   persist until unlinked is true, and this unlinking is performed on server close. So you are right, there is an ambiguity in this section in terms of who unlinks the pipe. Would you be interested in improving it through a PR?

   I am not sure how exactly the windows (external) behavior is different from UNIX,
   /cc @nodejs/platform-windows
2. gireeshpunathil commented on Mar 20, 2018

   

   gireeshpunathil

   on Mar 20, 2018

   Member

   More actions

   @boneskull - a PR in progress to address your concerns.

   Does it have something to do with garbage collection, or the socket object falling out of scope...?

   I did the below check and determined that the collection is done by the operating system, not Node.js . As you can see, the named pipe is removed when the program is abruptly terminated. This is different from UNIX where the DOMAIN socket persists on such abrupt termination. So the reference count is maintained by Windows.

   var net = require('net')
   const p= '\\\\.\\pipe\\test.sock'
     console.log(p)
   var k = net.createServer((s) => {
     s.end('hello!')
   }).listen(p, () => {
     var socket = net.connect(p)
     socket.on('data', (d) => {
       // k.close()
     })
   })

   $ node 1080.js
   \\.\pipe\test.sock
   ^C  // kill abruptly
   $
   

   from the powershell:

   PS> [System.IO.Directory]::GetFiles("\\.\\pipe\\") | grep test
   \\.\\pipe\\test.sock
   PS> [System.IO.Directory]::GetFiles("\\.\\pipe\\") | grep test
   PS>
   

   Hoep this helps!
3. gireeshpunathil commented on Mar 29, 2018

   

   gireeshpunathil

   on Mar 29, 2018

   Member

   More actions

   @boneskull - have a look at the PR and see if you believe the changes meets your expected clarity and coverage.
4. gireeshpunathil

   added a commit that references this issue on Apr 6, 2018

   doc: clarify lifecycle of domain sockets

   ...

   56d641c
5. gireeshpunathil commented on Apr 6, 2018

   

   gireeshpunathil

   on Apr 6, 2018

   Member

   More actions

   closing as addressed.
6. gireeshpunathil

   closed this as completedon Apr 6, 2018
7. Trott

   added a commit that references this issue on Apr 6, 2018

   doc: clarify lifecycle of domain sockets

   ...

   53aaa55
8. targos

   added a commit that references this issue on Apr 12, 2018

   doc: clarify lifecycle of domain sockets

   ...

   59a6581