Skip to content

parallel/test-http-connect broken on master #18940

Closed
Closed
parallel/test-http-connect broken on master#18940
Labels
confirmed-bugIssues and PRs for confirmed bugs.httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@Fishrock123
Fishrock123
opened on Feb 22, 2018
  • Version: master (2b7f920)
  • Platform: all
  • Subsystem: http, test
=== release test-http-connect ===
Path: parallel/test-http-connect
assert.js:74
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: 2 strictEqual 1
    at Server.server.on.common.mustCall (/Users/Jeremiah/Documents/node/test/parallel/test-http-connect.js:37:10)
    at Server.<anonymous> (/Users/Jeremiah/Documents/node/test/common/index.js:476:15)
    at Server.emit (events.js:129:13)
    at onParserExecuteCommon (_http_server.js:536:14)
    at onParserExecute (_http_server.js:483:3)

cc @BridgeAR who says he's on it.

Activity

  1. Fishrock123
    added
    confirmed-bugIssues and PRs for confirmed bugs.
    httpIssues and PRs related to the http subsystem.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Feb 22, 2018

  2. BridgeAR commented on Feb 22, 2018

    @BridgeAR
    BridgeAR
    on Feb 22, 2018
    Member

    It seems like 51be03c broke the test in combination with other PRs that landed earlier.

    @lpinca can you please take a look?

  3. BridgeAR commented on Feb 22, 2018

    @BridgeAR
    BridgeAR
    on Feb 22, 2018
    Member

    The CI was green for the PR: https://ci.nodejs.org/job/node-test-pull-request/13276/

  4. BridgeAR commented on Feb 22, 2018

    @BridgeAR
    BridgeAR
    on Feb 22, 2018
    Member

    To fix it I am just going to open a PR to change it to 2 right now as I can not look into it any further for the next couple hours.

  5. Fishrock123 commented on Feb 22, 2018

    @Fishrock123
    Fishrock123
    on Feb 22, 2018
    ContributorAuthor

    Can we revert the commits in question?

  6. addaleax commented on Feb 22, 2018

    @addaleax
    addaleax
    on Feb 22, 2018
    Member

    @BridgeAR Yeah, it’s just 51be03c interacting with 281d00e.

    I don’t think we need to do anything besides changing the number to 2 (and maybe recommending make test before pushing to master, if that’s not already in the collaborator guide).

  7. addaleax
    closed this as completedin fecc64don Feb 22, 2018

  8. BridgeAR commented on Feb 22, 2018

    @BridgeAR
    BridgeAR
    on Feb 22, 2018
    Member

    @addaleax I often thought about adding make test to my landing script but the issue is that it increases the overhead immensely. The tests take to long to always run them :/ (and it is not mandatory right now as far as I know).

  9. addaleax commented on Feb 22, 2018

    @addaleax
    addaleax
    on Feb 22, 2018
    Member

    @BridgeAR Yeah, I feel the pain of make test taking far too long … I’m not sure what to do about that. :/

  10. MayaLekova
    added a commit that references this issue on May 8, 2018

    test: fix test-http-connect

    acc76b0
  11. sjarmak
    added a commit that references this issue on Jul 27, 2026

    test: fix test-http-connect

    fecc64d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmed-bugIssues and PRs for confirmed bugs.httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions