Repository navigation
parallel/test-http-connect broken on master #18940
Description
- Version: master (2b7f920)
- Platform: all
- Subsystem: http, test
=== release test-http-connect ===
Path: parallel/test-http-connect
assert.js:74
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: 2 strictEqual 1
at Server.server.on.common.mustCall (/Users/Jeremiah/Documents/node/test/parallel/test-http-connect.js:37:10)
at Server.<anonymous> (/Users/Jeremiah/Documents/node/test/common/index.js:476:15)
at Server.emit (events.js:129:13)
at onParserExecuteCommon (_http_server.js:536:14)
at onParserExecute (_http_server.js:483:3)
cc @BridgeAR who says he's on it.
Activity
BridgeAR commentedon Feb 22, 2018
It seems like 51be03c broke the test in combination with other PRs that landed earlier.
@lpinca can you please take a look?
BridgeAR commentedon Feb 22, 2018
The CI was green for the PR: https://ci.nodejs.org/job/node-test-pull-request/13276/
BridgeAR commentedon Feb 22, 2018
To fix it I am just going to open a PR to change it to 2 right now as I can not look into it any further for the next couple hours.
Fishrock123 commentedon Feb 22, 2018
Can we revert the commits in question?
addaleax commentedon Feb 22, 2018
@BridgeAR Yeah, it’s just 51be03c interacting with 281d00e.
I don’t think we need to do anything besides changing the number to 2 (and maybe recommending
make testbefore pushing to master, if that’s not already in the collaborator guide).BridgeAR commentedon Feb 22, 2018
@addaleax I often thought about adding
make testto my landing script but the issue is that it increases the overhead immensely. The tests take to long to always run them :/ (and it is not mandatory right now as far as I know).addaleax commentedon Feb 22, 2018
@BridgeAR Yeah, I feel the pain of
make testtaking far too long … I’m not sure what to do about that. :/test: fix test-http-connect
test: fix test-http-connect