fsPromises.readFile ignores encoding option #19286

Activity

1. vsemozhetbyt

   added

   fsIssues and PRs related to file-system APIs and the fs module.Issues and PRs related to file-system APIs and the fs module.

   promisesIssues and PRs related to ECMAScript promises.Issues and PRs related to ECMAScript promises.

   on Mar 11, 2018
2. benjamingr commented on Mar 12, 2018

   

   benjamingr

   on Mar 12, 2018

   Member

   More actions

   Looks like a bug to me, fs.readFileSync returns a string for the same call.
3. benjamingr commented on Mar 12, 2018

   

   benjamingr

   on Mar 12, 2018

   Last edited by benjamingr

   Member

   More actions

   Can reproduce locally

   > await fsPromises.readFile('v8_build_config.json', 'utf-8')
   <Buffer 7b 22 76 38 5f 74 61 72 67 65 74 5f 63 70 75 22 3a 20 22 78 36 34 22 2c 20 22 69 73 5f 63 66 69 22 3a 20 66 61 6c 73 65 2c 20 22 74 61 72 67 65 74 5f ... >
   > fs.readFileSync('v8_build_config.json', 'utf-8')
   '{"v8_target_cpu": "x64", "is_cfi": false, "target_cpu": "x64", "is_ubsan_vptr": false, "is_gcov_coverage": false, "dcheck_always_on": false, "is_component_build": false, "is_asan": false, "is_debug": false, "v8_enable_i18n_support": true, "is_msan": false, "is_tsan": false, "v8_use_snapshot": true, "v8_enable_verify_predictable": false}'
   

   Note this works correctly when calling util.promisify on fs.readFile
4. benjamingr

   added

   confirmed-bugIssues and PRs for confirmed bugs.Issues and PRs for confirmed bugs.

   on Mar 12, 2018
5. benjamingr commented on Mar 12, 2018

   

   benjamingr

   on Mar 12, 2018

   Member

   More actions

   Looks like the encoding handling is missing in fs/promises and it is simply ignored https://github.com/nodejs/node/blob/master/lib/fs.js#L403-L405

   https://github.com/nodejs/node/blob/master/lib/fs/promises.js#L132 ignores options passed in.
6. benjamingr

   self-assigned this

   on Mar 12, 2018
7. benjamingr commented on Mar 12, 2018

   

   benjamingr

   on Mar 12, 2018

   Member

   More actions

   Going to tackle this one

   🎉React with 🎉1Reacted by jpenney1
8. benjamingr

   changed the title [-]Question: require('fs/promises')[/-] [+]fsPromises.readFile ignores encoding[/+] on Mar 12, 2018
9. benjamingr

   changed the title [-]fsPromises.readFile ignores encoding[/-] [+]fsPromises.readFile ignores encoding option[/+] on Mar 12, 2018
10. lpinca

    closed this as completedin e06ad5fon Mar 24, 2018
11. sjarmak

    added a commit that references this issue on Jul 27, 2026

    fs: use encoding in readFile

    ...

    e06ad5f