Skip to content

deps: patch V8 to 6.4.388.45 - #18751

Closed
MylesBorins wants to merge 1 commit into
masterfrom
V8-6.4.388.45
Closed

MylesBorins wants to merge 1 commit into
masterfrom
V8-6.4.388.45

Conversation

@MylesBorins

Copy link
Copy Markdown
Contributor

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Feb 13, 2018
@MylesBorins

Copy link
Copy Markdown
Contributor Author

@MylesBorins

Copy link
Copy Markdown
Contributor Author

@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 13, 2018
@MylesBorins

MylesBorins commented Feb 13, 2018 •

Copy link
Copy Markdown
Contributor Author

Single Plinux failure

trying one more time https://ci.nodejs.org/job/node-test-pull-request/13146/

@MylesBorins

Copy link
Copy Markdown
Contributor Author

Single plinux failure again... different failure

@MylesBorins

Copy link
Copy Markdown
Contributor Author

@MylesBorins

Copy link
Copy Markdown
Contributor Author

@MylesBorins

Copy link
Copy Markdown
Contributor Author

@targos

targos commented Feb 16, 2018

Copy link
Copy Markdown
Member

Landed in 36386dc

@targos targos closed this Feb 16, 2018
targos pushed a commit that referenced this pull request Feb 16, 2018
Refs: v8/v8@6.4.388.44...6.4.388.45

PR-URL: #18751
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos
targos deleted the V8-6.4.388.45 branch February 16, 2018 18:37
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Refs: v8/v8@6.4.388.44...6.4.388.45

PR-URL: nodejs#18751
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants