Skip to content

util: assign missed deprecation number - #19149

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:types-deprecation-number
Closed

util: assign missed deprecation number#19149
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:types-deprecation-number

Conversation

@addaleax

@addaleax addaleax commented Mar 5, 2018

Copy link
Copy Markdown
Member

Thanks to @ChALkeR for pointing this out.

Refs: #18415

@addaleax addaleax added util Issues and PRs related to the built-in util module. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Mar 5, 2018
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs involving general changes in the lib/ or src/ directories. label Mar 5, 2018
@addaleax addaleax added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed lib / src Issues and PRs involving general changes in the lib/ or src/ directories. labels Mar 5, 2018
@addaleax

addaleax commented Mar 5, 2018

Copy link
Copy Markdown
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/221/

@addaleax

addaleax commented Mar 5, 2018

Copy link
Copy Markdown
Member Author

Landed in ae31370

@addaleax addaleax closed this Mar 5, 2018
@addaleax
addaleax deleted the types-deprecation-number branch March 5, 2018 18:10
@addaleax addaleax removed fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Mar 5, 2018
addaleax added a commit that referenced this pull request Mar 5, 2018
@addaleax
util: assign missed deprecation number
ae31370 
Refs: #18415
PR-URL: #19149
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 6, 2018
Closed
4 tasks done
@MylesBorins

MylesBorins commented Mar 6, 2018

Copy link
Copy Markdown
Contributor

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
@addaleax @BridgeAR
util: assign missed deprecation number
148210f 
Refs: nodejs#18415
PR-URL: nodejs#19149
Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@addaleax @MayaLekova
util: assign missed deprecation number
b179dad 
Refs: nodejs#18415
PR-URL: nodejs#19149
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@addaleax @MylesBorins @BridgeAR @jasnell @nodejs-github-bot