Repository navigation
Conversation
Currently there are two tests that specify a third argument, a deprecation code string, when calling common.expectWarning. The function only takes two arguments and this third argument is not used. This commit removes the deprecation code.
nodejs-github-bot
added
the
test
Contributor
Author
hiroppy
approved these changes
Mar 13, 2018
cjihrig
approved these changes
Mar 13, 2018
lpinca
approved these changes
Mar 13, 2018
Member
|
No objection to this change, but going forward:
|
Trott
added
the
author ready
Contributor
Author
I think that would make sense. I can take a look but might not be until later this week or possibly next week. |
XadillaX
approved these changes
Mar 14, 2018
JacksonTian
approved these changes
Mar 14, 2018
jasnell
approved these changes
Mar 14, 2018
tniessen
approved these changes
Mar 14, 2018
Contributor
Author
|
Landed in 3ad7c1a. |
danbev
added a commit
that referenced
this pull request
Mar 15, 2018
Currently there are two tests that specify a third argument, a deprecation code string, when calling common.expectWarning. The function only takes two arguments and this third argument is not used. This commit removes the deprecation code. PR-URL: #19317 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Contributor
|
Should this be backported to |
3 tasks done
tniessen
removed
the
author ready
Member
|
This relies on a semver-major. I updated the labels accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there are two tests that specify a third argument, a
deprecation code string, when calling common.expectWarning. The
function only takes two arguments and this third argument is not used.
This commit removes the deprecation code.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes