Repository navigation
Conversation
nodejs-github-bot
added
doc
| * `destination` {stream.Writable} The destination for writing data | ||
| * `options` {Object} Pipe options | ||
| * `end` {boolean} End the writer when the reader ends. Defaults to `true`. | ||
| * Returns {stream.Writable} making it possible to set up chains of piped streams |
Contributor
There was a problem hiding this comment.
A nit: this is usually * Returns: (with a colon). The same for some other additions.
vsemozhetbyt
approved these changes
Mar 15, 2018
vsemozhetbyt
added
the
fast-track
Contributor
| * `destination` {stream.Writable} The destination for writing data | ||
| * `options` {Object} Pipe options | ||
| * `end` {boolean} End the writer when the reader ends. Defaults to `true`. | ||
| * Returns: {stream.Writable} making it possible to set up chains of piped streams |
Contributor
There was a problem hiding this comment.
Sorry, linter issue:
863:82 warning Line must be at most 80 characters maximum-line-length remark-lint
Contributor
starkwang
approved these changes
Mar 15, 2018
hiroppy
approved these changes
Mar 15, 2018
vsemozhetbyt
pushed a commit
that referenced
this pull request
Mar 15, 2018
PR-URL: #19361 Refs: #11135 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Contributor
|
Landed in a2c0fcc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #11135
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc, stream