Skip to content

errors: fix typo in internal/errors.js - #19800

Closed
davidmarkclements wants to merge 1 commit into
nodejs:masterfrom
davidmarkclements:ERR_NAPI_INVALID_DATAVIEW_ARGS-typo
Closed

errors: fix typo in internal/errors.js#19800
davidmarkclements wants to merge 1 commit into
nodejs:masterfrom
davidmarkclements:ERR_NAPI_INVALID_DATAVIEW_ARGS-typo

Conversation

@davidmarkclements

@davidmarkclements davidmarkclements commented Apr 4, 2018

Copy link
Copy Markdown
Member

corrects "eqaul" to "equal" in the description
for the ERR_NAPI_INVALID_DATAVIEW_ARGS error message

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

davidmarkclements
errors: fix typo in internal/errors.js
d77daad 
corrects "eqaul" to "equal" in the description
for the ERR_NAPI_INVALID_DATAVIEW_ARGS error message
@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originating in Node.js core. label Apr 4, 2018
@BridgeAR BridgeAR added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 4, 2018
@vsemozhetbyt

vsemozhetbyt commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/427/

@vsemozhetbyt

vsemozhetbyt commented Apr 4, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Not sure if the full CI is needed. It seems no tests check this message literally:

https://github.com/nodejs/node/search?utf8=%E2%9C%93&q=eqaul&type=

@vsemozhetbyt vsemozhetbyt added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 4, 2018
@lpinca

lpinca commented Apr 6, 2018

Copy link
Copy Markdown
Member

Landed in f8b3774.

@lpinca lpinca closed this Apr 6, 2018
lpinca pushed a commit that referenced this pull request Apr 6, 2018
davidmarkclements @lpinca
errors: fix typo in internal/errors.js
f8b3774 
Corrects "eqaul" to "equal" in the description for the
ERR_NAPI_INVALID_DATAVIEW_ARGS error message.

PR-URL: #19800
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2018
davidmarkclements @targos
errors: fix typo in internal/errors.js
9603c4a 
Corrects "eqaul" to "equal" in the description for the
ERR_NAPI_INVALID_DATAVIEW_ARGS error message.

PR-URL: #19800
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. errors Issues and PRs related to JavaScript errors originating in Node.js core. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@davidmarkclements @vsemozhetbyt @lpinca @jasnell @targos @cjihrig @tniessen @BridgeAR @trivikr @nodejs-github-bot