Skip to content

doc: improve CCM example - #19851

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:doc-crypto-improve-ccm-example
Closed

tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:doc-crypto-improve-ccm-example

Conversation

@tniessen

@tniessen tniessen commented Apr 6, 2018

Copy link
Copy Markdown
Member

The nonce must be transmitted along with ciphertext and tag.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

The nonce must be transmitted along with ciphertext and tag.
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation. labels Apr 6, 2018
@BridgeAR

BridgeAR commented Apr 8, 2018

Copy link
Copy Markdown
Member

@BridgeAR BridgeAR added fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Apr 8, 2018
@tniessen tniessen removed the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 9, 2018
@tniessen

tniessen commented Apr 9, 2018

Copy link
Copy Markdown
Member Author

Landed in 99c77dc.

@tniessen tniessen closed this Apr 9, 2018
tniessen added a commit that referenced this pull request Apr 9, 2018
The nonce must be transmitted along with ciphertext and tag.

PR-URL: #19851
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos added dont-land-on-v9.x and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants