Repository navigation
Conversation
This test currently fails when configured --without-ssl: Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support This commit moves the require of http2 to come after the crypto check to avoid the error.
nodejs-github-bot
added
the
test
Contributor
Author
richardlau
approved these changes
Apr 10, 2018
trivikr
approved these changes
Apr 10, 2018
lpinca
approved these changes
Apr 10, 2018
tniessen
approved these changes
Apr 10, 2018
cjihrig
approved these changes
Apr 10, 2018
jasnell
approved these changes
Apr 10, 2018
jasnell
added
the
fast-track
Contributor
Author
|
Landed in 4ac7753. |
danbev
added a commit
that referenced
this pull request
Apr 11, 2018
This test currently fails when configured --without-ssl: Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support This commit moves the require of http2 to come after the crypto check to avoid the error. PR-URL: #19907 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2018
This test currently fails when configured --without-ssl: Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support This commit moves the require of http2 to come after the crypto check to avoid the error. PR-URL: #19907 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
This test currently fails when configured --without-ssl: Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support This commit moves the require of http2 to come after the crypto check to avoid the error. PR-URL: #19907 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test currently fails when configured --without-ssl:
This commit moves the require of http2 to come after the crypto check to
avoid the error.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes