Skip to content

doc: unify End-of-Life marker - #19942

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:doc-unify-eol-marker
Closed

doc: unify End-of-Life marker#19942
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:doc-unify-eol-marker

Conversation

@tniessen

@tniessen tniessen commented Apr 11, 2018

Copy link
Copy Markdown
Member

There are 20 occurrences of End-of-Life vs only two of End-of-life.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Apr 11, 2018
@BridgeAR BridgeAR added fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Apr 11, 2018
@BridgeAR

BridgeAR commented Apr 11, 2018

Copy link
Copy Markdown
Member

This does not seem to need a CI run due to the obvious change.

@tniessen

tniessen commented Apr 11, 2018

Copy link
Copy Markdown
Member Author

Landed in 78cd826.

@tniessen tniessen closed this Apr 11, 2018
tniessen added a commit that referenced this pull request Apr 11, 2018
@tniessen
doc: unify End-of-Life marker
78cd826 
PR-URL: #19942
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2018
@tniessen @targos
doc: unify End-of-Life marker
0cbdcaf 
PR-URL: #19942
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@tniessen @jasnell
doc: unify End-of-Life marker
7d2814e 
PR-URL: #19942
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@tniessen tniessen removed author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
+1 more reviewer
@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen @BridgeAR @jasnell @cjihrig @vsemozhetbyt @nodejs-github-bot