Repository navigation
Conversation
This commit removes the assignment of exports since it is not used in these files and there is no harm re-assigning module.exports.
nodejs-github-bot
added
errors
Contributor
Author
lpinca
approved these changes
Apr 19, 2018
Member
And it is reassigned anyway. We are also documenting this pattern in https://nodejs.org/api/modules.html#modules_exports_shortcut. I honestly never liked it, I think it's confusing for newcomers. |
JacksonTian
approved these changes
Apr 19, 2018
Contributor
|
I don't like this pattern too. |
cjihrig
approved these changes
Apr 19, 2018
jasnell
approved these changes
Apr 19, 2018
trivikr
approved these changes
Apr 20, 2018
tniessen
approved these changes
Apr 20, 2018
Member
|
Re-run for CI node-test-commit-osx https://ci.nodejs.org/job/node-test-commit-osx/17983/ |
BridgeAR
added
the
author ready
Contributor
|
Landed in f31fc93 |
apapirovski
pushed a commit
that referenced
this pull request
Apr 22, 2018
This commit removes the assignment of exports since it is not used in these files and there is no harm re-assigning module.exports. PR-URL: #20143 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 23, 2018
This commit removes the assignment of exports since it is not used in these files and there is no harm re-assigning module.exports. PR-URL: #20143 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the assignment of
exportssince it is not usedin these files and there is no harm re-assigning
module.exports.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes