Repository navigation
Conversation
nodejs-github-bot
added
c++
addaleax
approved these changes
Apr 21, 2018
tniessen
added
the
fast-track
lpinca
approved these changes
Apr 21, 2018
cjihrig
approved these changes
Apr 21, 2018
Member
Author
BridgeAR
added
the
author ready
Member
Author
|
Landed in 854f840. |
tniessen
added a commit
that referenced
this pull request
Apr 22, 2018
PR-URL: #20197 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 23, 2018
PR-URL: #20197 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
tniessen
removed
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The semantics of the conditional assignment here are closer to
std::minthanstd::max.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes