Repository navigation
Conversation
nodejs-github-bot
added
the
v8 engine
mmarchini
approved these changes
Apr 6, 2020
cjihrig
approved these changes
Apr 6, 2020
Collaborator
targos
added
the
author ready
addaleax
removed
the
author ready
Member
|
@targos I don’t think V8 CI is supposed to be all red, right? |
Member
Author
|
@addaleax unfortunately, it currently is: nodejs/build#2256 |
Contributor
|
Is it gonna drop into the node 14? 🥺 |
Collaborator
Member
|
@targos CI is green, I guess that means we should land it? |
Member
Author
|
Yes, this can land. I'll do it tomorrow if nobody beats me to it |
Member
Author
|
Rebased on master to unbreak V8 CI and updated to 8.1.307.30 |
Collaborator
Collaborator
BethGriggs
approved these changes
Apr 20, 2020
Member
Author
|
Landed in 3664807 |
targos
added a commit
that referenced
this pull request
Apr 20, 2020
PR-URL: #32693 Refs: v8/v8@8.1.307.26...8.1.307.28 Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 20, 2020
PR-URL: #32693 Refs: v8/v8@8.1.307.26...8.1.307.28 Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@8.1.307.26...8.1.307.28