Skip to content

test: move buffer-as-path symlink test to its own test file - #34569

Closed
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:symlink
Closed

test: move buffer-as-path symlink test to its own test file#34569
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:symlink

Conversation

@Trott

@Trott Trott commented Jul 30, 2020

Copy link
Copy Markdown
Member

The buffer-as-path test for fs.symlinkSync() is a bit unusual and
potentially error-prone embedded in the general fs.symlink() test. Move
it to its own test file.

Refs: https://github.com/nodejs/node/pull/34540/files#r463168354

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Jul 30, 2020
Trott
Trott commented Jul 30, 2020
View reviewed changes
Comment thread test/parallel/test-fs-symlink-buffer-path.js Outdated

@Trott Trott Jul 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't usually include the Joyent copyright in newly-written tests but this one was substantially copied from test-fs-symlink.js so the copyright is included.

@Trott Trott mentioned this pull request Jul 30, 2020
Closed
3 tasks
@mmarchini mmarchini added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 31, 2020
@Trott

Trott commented Aug 1, 2020

Copy link
Copy Markdown
Member Author

@nodejs/testing

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 1, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 1, 2020 •
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32597/ ✅

@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 1, 2020
This was referenced Aug 2, 2020
Open
Open
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 2, 2020 •
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32600/ ✅

@Trott

Trott commented Aug 2, 2020

Copy link
Copy Markdown
Member Author

@nodejs/fs

@Trott

Trott commented Aug 2, 2020

Copy link
Copy Markdown
Member Author

@nodejs/collaborators This could use another review.

This was referenced Aug 3, 2020
Open
Open
@Trott

Trott commented Aug 3, 2020

Copy link
Copy Markdown
Member Author

Landed in a9c5b87

Trott added a commit that referenced this pull request Aug 3, 2020
@Trott
test: move buffer-as-path symlink test to its own test file
a9c5b87 
The buffer-as-path test for fs.symlinkSync() is a bit unusual and
potentially error-prone embedded in the general fs.symlink() test. Move
it to its own test file.

Refs: https://github.com/nodejs/node/pull/34540/files#r463168354

PR-URL: #34569
Reviewed-By: Pranshu Srivastava <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@Trott Trott closed this Aug 3, 2020
@Trott
Trott deleted the symlink branch August 3, 2020 00:39
@github-actions github-actions Bot mentioned this pull request Aug 4, 2020
Open
12 tasks
This was referenced Aug 4, 2020
Open
Open
Open
codebytere pushed a commit that referenced this pull request Aug 5, 2020
@Trott @codebytere
test: move buffer-as-path symlink test to its own test file
9ed424f 
The buffer-as-path test for fs.symlinkSync() is a bit unusual and
potentially error-prone embedded in the general fs.symlink() test. Move
it to its own test file.

Refs: https://github.com/nodejs/node/pull/34540/files#r463168354

PR-URL: #34569
Reviewed-By: Pranshu Srivastava <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
This was referenced Aug 6, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@codebytere codebytere mentioned this pull request Aug 10, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@Trott @MylesBorins
test: move buffer-as-path symlink test to its own test file
d7ff868 
The buffer-as-path test for fs.symlinkSync() is a bit unusual and
potentially error-prone embedded in the general fs.symlink() test. Move
it to its own test file.

Refs: https://github.com/nodejs/node/pull/34540/files#r463168354

PR-URL: #34569
Reviewed-By: Pranshu Srivastava <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: move buffer-as-path symlink test to its own test file
93c917c 
The buffer-as-path test for fs.symlinkSync() is a bit unusual and
potentially error-prone embedded in the general fs.symlink() test. Move
it to its own test file.

Refs: https://github.com/nodejs/node/pull/34540/files#r463168354

PR-URL: #34569
Reviewed-By: Pranshu Srivastava <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@Trott @danielleadams
test: move buffer-as-path symlink test to its own test file
402ba0b 
The buffer-as-path test for fs.symlinkSync() is a bit unusual and
potentially error-prone embedded in the general fs.symlink() test. Move
it to its own test file.

Refs: https://github.com/nodejs/node/pull/34540/files#r463168354

PR-URL: #34569
Reviewed-By: Pranshu Srivastava <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@Flarna Flarna Flarna approved these changes
+1 more reviewer
@rexagod rexagod rexagod approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Trott @nodejs-github-bot @addaleax @Flarna @rexagod @targos @mmarchini @BethGriggs