Skip to content

lib: add primitive fast path to structuredClone - #64190

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
araujogui:structuredclone-primitive-fast-path
Sep 20, 2026
Merged

lib: add primitive fast path to structuredClone#64190
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
araujogui:structuredclone-primitive-fast-path

Conversation

@araujogui

@araujogui araujogui commented Jun 28, 2026

Copy link
Copy Markdown
Member
Benchmark 
                                                    confidence improvement accuracy (*)    (**)   (***)
misc/structured-clone.js n=10000 type='arraybuffer'                 0.52 %       ±1.04%  ±1.38%  ±1.80%
misc/structured-clone.js n=10000 type='object'                      0.35 %       ±0.98%  ±1.31%  ±1.72%
misc/structured-clone.js n=10000 type='primitive'          ***    480.42 %      ±27.38% ±36.89% ±48.97%
misc/structured-clone.js n=10000 type='string'             ***    629.04 %       ±9.84% ±13.26% ±17.60%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 4 comparisons, you can thus expect the following amount of false-positive results:
  0.20 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.04 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

Copilot AI review requested due to automatic review settings June 28, 2026 14:06
@nodejs-github-bot

nodejs-github-bot commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance

Copilot AI reviewed Jun 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. worker Issues and PRs related to the worker_threads module and Worker API. labels Jun 28, 2026
@araujogui
araujogui force-pushed the structuredclone-primitive-fast-path branch 2 times, most recently from 1721b72 to 14c1d64 Compare June 28, 2026 17:59
mertcanaltin
mertcanaltin approved these changes Jun 28, 2026
View reviewed changes

@mertcanaltin mertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

H4ad
H4ad reviewed Jun 28, 2026
View reviewed changes

@H4ad H4ad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this has a specification defined at https://html.spec.whatwg.org/multipage/structured-data.html#structuredserializeinternal, not sure we if we can/should bypass WebIDL implementation even if it has the same behavior and produces the same value.

Comment thread benchmark/misc/structured-clone.js Outdated
mcollina
mcollina approved these changes Jun 29, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@H4ad H4ad added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 16, 2026
@araujogui araujogui added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 18, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 18, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77605/

@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77636/

@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77644/

@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77649/

@nodejs-github-bot

nodejs-github-bot commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77660/

@mcollina mcollina added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 20, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 20, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

Commit Queue failed

   ✖  1 GitHub CI job(s) cancelled:
   ✖    - lint-nix: CANCELLED (https://github.com/nodejs/node/actions/runs/28375202512/job/84062897600)

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output 
�[36m⠋�[39m Loading data for nodejs/node/pull/64190
�[36m⠋�[39m Loading data for nodejs/node/pull/64190
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/64190
�[36m⠋�[39m Getting reviews from nodejs/node/pull/64190
�[36m⠋�[39m Getting comments from nodejs/node/pull/64190
�[36m⠋�[39m Getting commits from nodejs/node/pull/64190
✔  Done loading data for nodejs/node/pull/64190
----------------------------------- PR info ------------------------------------
Title      lib: add primitive fast path to structuredClone (#64190)
Author     Guilherme Araújo <[email protected]> (@araujogui)
Branch     araujogui:structuredclone-primitive-fast-path -> nodejs:main
Labels     author ready, worker, needs-ci, commit-queue
Commits    2
 - lib: add primitive fast path to structuredClone
 - benchmark: rename structuredClone primitive type to int
Committers 1
 - Guilherme Araújo <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/64190
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Ilyas Shabi <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64190
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Ilyas Shabi <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 28 Jun 2026 14:06:01 GMT
   ✔  Approvals: 5
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/64190#pullrequestreview-4589605349
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/64190#pullrequestreview-5225149758
   ✔  - Ilyas Shabi (@IlyasShabi): https://github.com/nodejs/node/pull/64190#pullrequestreview-5226702063
   ✔  - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/64190#pullrequestreview-5228534841
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64190#pullrequestreview-5251026490
   ✖  1 GitHub CI job(s) cancelled:
   ✖    - lint-nix: CANCELLED (https://github.com/nodejs/node/actions/runs/28375202512/job/84062897600)
   ℹ  Last Full PR CI on 2026-09-20T02:58:14Z: https://ci.nodejs.org/job/node-test-pull-request/77660/
�[36m⠙�[39m Querying data for job/node-test-pull-request/77660/
�[36m⠙�[39m Querying data for job/node-test-pull-request/77660/
�[36m⠙�[39m Querying API for job/node-test-pull-request/77660/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

@araujogui
araujogui force-pushed the structuredclone-primitive-fast-path branch from 10fb3d7 to c1e9fe7 Compare September 20, 2026 15:17
@codecov

codecov Bot commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (ea08334) to head (c1e9fe7).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #64190      +/-   ##
==========================================
- Coverage   92.75%   90.28%   -2.48%     
==========================================
  Files         421      790     +369     
  Lines      190606   271993   +81387     
  Branches    29206    51934   +22728     
==========================================
+ Hits       176790   245558   +68768     
- Misses      13488    16944    +3456     
- Partials      328     9491    +9163
Files with missing lines Coverage Δ
lib/internal/worker/js_transferable.js 98.55% <100.00%> (+0.91%) ⬆️

... and 497 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 20, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77686/

@araujogui araujogui added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 20, 2026
@nodejs-github-bot
nodejs-github-bot merged commit bfb84d3 into nodejs:main Sep 20, 2026
76 checks passed
@nodejs-github-bot

nodejs-github-bot commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

Landed in bfb84d3

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 20, 2026
aduh95 pushed a commit that referenced this pull request Sep 27, 2026
@araujogui @aduh95
lib: add primitive fast path to structuredClone
46a8a5d 
Signed-off-by: Guilherme Araújo <[email protected]>
PR-URL: #64190
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Ilyas Shabi <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@H4ad H4ad H4ad approved these changes
@IlyasShabi IlyasShabi IlyasShabi approved these changes
@gurgunday gurgunday gurgunday approved these changes
+1 more reviewer
@mertcanaltin mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. worker Issues and PRs related to the worker_threads module and Worker API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@araujogui @nodejs-github-bot @mcollina @jasnell @H4ad @IlyasShabi @mertcanaltin @gurgunday