Repository navigation
doc: clarify http Agent keepSocketAlive behavior - #66252
Merged
nodejs-github-bot merged 1 commit intoOct 8, 2026
Merged
Conversation
Signed-off-by: Efe Karasakal <[email protected]>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
lpinca
approved these changes
Sep 24, 2026
mertcanaltin
approved these changes
Oct 3, 2026
pimterry
approved these changes
Oct 8, 2026
pimterry
added
the
commit-queue
Collaborator
|
Landed in 855e3f7 |
nodejs-github-bot
removed
the
commit-queue
richardlau
pushed a commit
that referenced
this pull request
Oct 12, 2026
Signed-off-by: Efe Karasakal <[email protected]> PR-URL: #66252 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tim Perry <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
http.Agent#keepSocketAlive()documentation to reflect its current behavior. Removes the outdated implementation example. The implementation has drifted away from the example long time ago see