Skip to content

crypto: remove select Web Crypto warnings - #66312

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:webcrypto-remove-warnings
Oct 4, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:webcrypto-remove-warnings

Conversation

@panva

@panva panva commented Sep 26, 2026

Copy link
Copy Markdown
Member

Remove ExperimentalWarning from algorithms and methods that are on their way to an unflagged browser implementation.

Remove ExperimentalWarning from algorithms and methods that are on their
way to an unflagged browser implementation.

Signed-off-by: Filip Skokan <[email protected]>
@panva panva added crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. webcrypto Issues and PRs related to the Web Crypto API. labels Sep 26, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 26, 2026
@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (66f26d3) to head (79e31f2).
⚠️ Report is 144 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66312      +/-   ##
==========================================
- Coverage   90.38%   90.36%   -0.02%     
==========================================
  Files         790      790              
  Lines      274497   274491       -6     
  Branches    52557    52564       +7     
==========================================
- Hits       248100   248043      -57     
- Misses      16879    16929      +50     
- Partials     9518     9519       +1     
Files with missing lines Coverage Δ
lib/internal/crypto/util.js 98.18% <100.00%> (+<0.01%) ⬆️
lib/internal/crypto/webcrypto.js 98.11% <ø> (-0.01%) ⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva
panva requested a review from jasnell September 30, 2026 06:27
@aduh95

aduh95 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Do you have some reference about the unflagging on browsers?

@panva

panva commented Oct 3, 2026

Copy link
Copy Markdown
Member Author

Do you have some reference about the unflagging on browsers?

https://developer.chrome.com/blog/chrome-155-beta#algorithm_updates_in_webcrypto

@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 4, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 773bdd1 into nodejs:main Oct 4, 2026
91 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 773bdd1

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 4, 2026
@panva
panva deleted the webcrypto-remove-warnings branch October 4, 2026 19:39
richardlau pushed a commit that referenced this pull request Oct 12, 2026
Remove ExperimentalWarning from algorithms and methods that are on their
way to an unflagged browser implementation.

Signed-off-by: Filip Skokan <[email protected]>
PR-URL: #66312
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. webcrypto Issues and PRs related to the Web Crypto API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants