Skip to content

process: mark process.finalization as release candidate - #66436

Closed
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:process-finalization-rc
Closed

process: mark process.finalization as release candidate#66436
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:process-finalization-rc

Conversation

@mcollina

@mcollina mcollina commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Moves process.finalization.register(), registerBeforeExit() and unregister() from Stability 1.1 (Active Development) to 1.2 (Release candidate) and drops the experimental warning.

AI generated, reviewed by me

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Oct 1, 2026
@mcollina
mcollina force-pushed the process-finalization-rc branch from c19fe9e to 5ead480 Compare October 1, 2026 15:05
@mcollina
mcollina requested review from H4ad, aduh95 and jasnell and removed request for H4ad October 1, 2026 15:10
@codecov

codecov Bot commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.38%. Comparing base (ebef774) to head (5ead480).
⚠️ Report is 321 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #66436      +/-   ##
==========================================
+ Coverage   90.28%   90.38%   +0.10%     
==========================================
  Files         790      792       +2     
  Lines      271642   275719    +4077     
  Branches    51846    52864    +1018     
==========================================
+ Hits       245260   249220    +3960     
- Misses      16889    16896       +7     
- Partials     9493     9603     +110
Files with missing lines Coverage Δ
lib/internal/process/finalization.js 100.00% <ø> (ø)

... and 195 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 3, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 3, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78151/

@H4ad H4ad added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 3, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 3, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78153/

@mcollina mcollina added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 4, 2026
@github-actions github-actions Bot added resume-ci-failed Resuming CI with the resume-ci label failed and requires manual intervention. and removed resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. labels Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Failed to resume CI

✖ Failed to load PR CI job 78153: Unexpected token '<', ..."

Full Auto Start CI output 
�[36m⠋�[39m Validating Jenkins credentials
�[36m⠋�[39m Validating Jenkins credentials
✔  Jenkins credentials valid
�[36m⠙�[39m Looking for CI runs for pull request 66436
�[36m⠙�[39m Looking for CI runs for pull request 66436
�[36m⠙�[39m Getting PR from nodejs/node/pull/66436
�[36m⠙�[39m Getting reviews from nodejs/node/pull/66436
�[36m⠙�[39m Getting comments from nodejs/node/pull/66436
✔  Found PR CI job 78153
�[36m⠹�[39m Querying data for job/node-test-pull-request/78153/
�[36m⠹�[39m Querying data for job/node-test-pull-request/78153/
�[36m⠹�[39m Querying API for job/node-test-pull-request/78153/

[DEBUG] [SyntaxError: Unexpected token '<', ..."    
  
  <!DOCTYPE "... is not valid JSON]
✖  Failed to load PR CI job 78153: Unexpected token '<', ..."    
  
  <!DOCTYPE "... is not valid JSON

View workflow run

mcollina added a commit that referenced this pull request Oct 10, 2026
@mcollina
process: mark process.finalization as release candidate
4e09bf3 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #66436
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mcollina

mcollina commented Oct 10, 2026

Copy link
Copy Markdown
Member Author

Landed in 4e09bf3

@mcollina mcollina closed this Oct 10, 2026
richardlau pushed a commit that referenced this pull request Oct 12, 2026
@mcollina @richardlau
process: mark process.finalization as release candidate
44cf370 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #66436
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions Bot mentioned this pull request Oct 12, 2026
Open
richardlau pushed a commit that referenced this pull request Oct 12, 2026
@mcollina @richardlau
process: mark process.finalization as release candidate
1aa10d8 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #66436
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@ronag ronag ronag approved these changes
@H4ad H4ad H4ad approved these changes
@aduh95 aduh95 Awaiting requested review from aduh95

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. resume-ci-failed Resuming CI with the resume-ci label failed and requires manual intervention.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mcollina @nodejs-github-bot @jasnell @ronag @H4ad @panva