Repository navigation
doc: clarify revert PR label policy - #66529
Merged
Merged
Conversation
Signed-off-by: Antoine du Hamel <[email protected]>
Collaborator
|
Review requested:
|
MikeMcC399
approved these changes
Oct 5, 2026
ShogunPanda
approved these changes
Oct 5, 2026
RafaelGSS
approved these changes
Oct 5, 2026
Contributor
|
You may want to also consider adding a manual check instruction for releasers into https://github.com/nodejs/node/blob/main/doc/contributing/releases.md that there are no redundant pairs of commit + revert-commit in a release proposal. Just in case the instructions being updated here are overlooked or not followed. (An automated check would be better, if possible.) I don't know how much sense this makes. As a releaser you are the best judge. |
aduh95
added
author ready
jasnell
approved these changes
Oct 5, 2026
Renegade334
approved these changes
Oct 5, 2026
lpinca
approved these changes
Oct 5, 2026
UlisesGascon
approved these changes
Oct 6, 2026
legendecas
approved these changes
Oct 6, 2026
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failedThe pull request was removed from the Commit Queue and labeled
commit-queue-failed
Full Commit Queue output |
Contributor
Author
|
Landed in 49d2d81 |
gabylb
pushed a commit
to gabylb/node
that referenced
this pull request
Oct 7, 2026
Signed-off-by: Antoine du Hamel <[email protected]> PR-URL: nodejs#66529 Reviewed-By: Mike McCready <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Oct 12, 2026
Signed-off-by: Antoine du Hamel <[email protected]> PR-URL: #66529 Reviewed-By: Mike McCready <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.