Skip to content

build,test: enable temporal support on no-ICU and system-ICU builds - #66697

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:temporal-shared-no-icu
Open

aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:temporal-shared-no-icu

Conversation

@aduh95

@aduh95 aduh95 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Refs: #65992
Refs: #66183

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 13, 2026

@sxa sxa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adding @richardlau as reviewer since he put the comment in and is also preparing the current 26 release :-)

@sxa
sxa requested a review from richardlau October 13, 2026 09:01
@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.49%. Comparing base (c883ccf) to head (3b79e5e).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66697      +/-   ##
==========================================
- Coverage   92.82%   90.49%   -2.34%     
==========================================
  Files         422      791     +369     
  Lines      194189   277088   +82899     
  Branches    30039    53281   +23242     
==========================================
+ Hits       180257   250737   +70480     
- Misses      13607    16759    +3152     
- Partials      325     9592    +9267     

see 499 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlau richardlau added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

@richardlau

Copy link
Copy Markdown
Member

I'll stick a fast-track label on this. If we can get a clean CI on this today in the next few (say three) hours then I'll pull it into #66684.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants