Skip to content

build: port make_temporal_zoneinfo_cpp to GYP - #66183

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:fix-temporal-no-icu
Sep 24, 2026
Merged

build: port make_temporal_zoneinfo_cpp to GYP#66183
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:fix-temporal-no-icu

Conversation

@aduh95

@aduh95 aduh95 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Refs: #62676

@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Sep 21, 2026
@aduh95 aduh95 mentioned this pull request Sep 21, 2026
Closed
Renegade334
Renegade334 reviewed Sep 21, 2026
View reviewed changes
Comment thread tools/v8_gypfiles/v8.gyp Outdated
@Renegade334

Renegade334 commented Sep 24, 2026

Copy link
Copy Markdown
Member

Successful build on linux-x64 / gcc.

> process.config.variables.v8_enable_i18n_support
0
> Temporal.Now.zonedDateTimeISO('Europe/Amsterdam').toString()
'2026-09-24T11:32:53.33537793+02:00[Europe/Amsterdam]'

@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 24, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 24, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77858/

@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7397/

@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7397/

@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7397/

@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Sep 24, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 9800c29 into nodejs:main Sep 24, 2026
81 checks passed
@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

Landed in 9800c29

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 24, 2026
@Renegade334 Renegade334 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Sep 26, 2026
aduh95 added a commit that referenced this pull request Sep 27, 2026
@aduh95
build: port make_temporal_zoneinfo_cpp to GYP
88aa3da 
Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: #66183
Refs: #62676
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
aduh95 added a commit that referenced this pull request Sep 28, 2026
@aduh95
build: port make_temporal_zoneinfo_cpp to GYP
9066d33 
Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: #66183
Refs: #62676
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
Merged
@aduh95
aduh95 deleted the fix-temporal-no-icu branch October 13, 2026 07:15
@aduh95 aduh95 mentioned this pull request Oct 13, 2026
Merged
nodejs-github-bot pushed a commit that referenced this pull request Oct 13, 2026
@aduh95
build,test: enable temporal support on no-ICU and system-ICU builds
ea6ec93 
Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: #66697
Refs: #65992
Refs: #66183
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
richardlau pushed a commit that referenced this pull request Oct 13, 2026
@aduh95 @richardlau
build,test: enable temporal support on no-ICU and system-ICU builds
f88c2f8 
Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: #66697
Refs: #65992
Refs: #66183
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
anonyein pushed a commit to anonyein/Javet that referenced this pull request Oct 13, 2026
anyone
🐛 fix: Skip the v8.gyp temporal patch adopted upstream in Node.js v26…
bc4128b 
….11.0

Node.js v26.11.0 (nodejs/node#66183) ports the make_temporal_zoneinfo_cpp action as the temporal_zoneinfo64_data target, so patch_node_build.ts failed with 'does not contain the text to replace' and broke the Android Node Build on 26.11.1. Detect the upstream fix and skip the patch, keeping older Node.js versions patched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renegade334 Renegade334 Renegade334 left review comments
@richardlau richardlau richardlau approved these changes
@legendecas legendecas legendecas approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95 @nodejs-github-bot @Renegade334 @richardlau @legendecas