Skip to content

doc: standardize on make -j8 - #8678

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:j8
Closed

Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:j8

Conversation

@Trott

@Trott Trott commented Sep 21, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Most of the docs recommend make -j8. The one exception is the pull
request template which recommends make -j4. This changes the pull
request template so that it is in line with the other docs.

Most of the docs recommend `make -j8`. The one exception is the pull
request template which recommends `make -j4`. This changes the pull
request template so that it is in line with the other docs.
@Trott Trott added the doc Issues and PRs related to Node.js documentation. label Sep 21, 2016
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 21, 2016
@targos

targos commented Sep 21, 2016

Copy link
Copy Markdown
Member

LGTM

@lpinca lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbergstroem

Copy link
Copy Markdown
Member

LGTM

@imyller imyller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

Copy link
Copy Markdown
Member

LGTM

@danbev

danbev commented Sep 22, 2016

Copy link
Copy Markdown
Contributor

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Sep 23, 2016
Most of the docs recommend `make -j8`. The one exception is the pull
request template which recommends `make -j4`. This changes the pull
request template so that it is in line with the other docs.

PR-URL: nodejs#8678
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@Trott

Trott commented Sep 23, 2016

Copy link
Copy Markdown
Member Author

Landed in adb3ca6

@Trott Trott closed this Sep 23, 2016
jasnell pushed a commit that referenced this pull request Sep 29, 2016
Most of the docs recommend `make -j8`. The one exception is the pull
request template which recommends `make -j4`. This changes the pull
request template so that it is in line with the other docs.

PR-URL: #8678
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
Most of the docs recommend `make -j8`. The one exception is the pull
request template which recommends `make -j4`. This changes the pull
request template so that it is in line with the other docs.

PR-URL: #8678
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@Trott
Trott deleted the j8 branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.