Skip to content

chore: ignore wasm file for npm publishing - #1219

Merged
mcollina merged 1 commit into
nodejs:mainfrom
Kikobeats:npmignore
Feb 10, 2022
Merged

chore: ignore wasm file for npm publishing#1219
mcollina merged 1 commit into
nodejs:mainfrom
Kikobeats:npmignore

Conversation

@Kikobeats

@Kikobeats Kikobeats commented Feb 10, 2022

Copy link
Copy Markdown
Contributor

After #1183, WASM files are no more necessary to be shipped as part of the NPM bundle

@Kikobeats Kikobeats mentioned this pull request Feb 10, 2022
Merged
@mcollina

mcollina commented Feb 10, 2022

Copy link
Copy Markdown
Member

I thiink we need to add a bit more things from .gitignore, have you tried looking inside the generated package?

@Kikobeats

Kikobeats commented Feb 10, 2022

Copy link
Copy Markdown
Contributor Author

@mcollina I think the rest of things are ok. This is how it looks like right now:

.
├── LICENSE
├── README.md
├── docs
│   ├── api
│   │   ├── Agent.md
│   │   ├── BalancedPool.md
│   │   ├── Client.md
│   │   ├── Connector.md
│   │   ├── DiagnosticsChannel.md
│   │   ├── Dispatcher.md
│   │   ├── Errors.md
│   │   ├── MockAgent.md
│   │   ├── MockClient.md
│   │   ├── MockErrors.md
│   │   ├── MockPool.md
│   │   ├── Pool.md
│   │   ├── ProxyAgent.md
│   │   └── api-lifecycle.md
│   ├── assets
│   │   └── lifecycle-diagram.png
│   └── best-practices
│       ├── client-certificate.md
│       ├── mocking-request.md
│       ├── proxy.md
│       └── writing-tests.md
├── index.d.ts
├── index.js
├── lib
│   ├── agent.js
│   ├── api
│   │   ├── abort-signal.js
│   │   ├── api-connect.js
│   │   ├── api-pipeline.js
│   │   ├── api-request.js
│   │   ├── api-stream.js
│   │   ├── api-upgrade.js
│   │   ├── index.js
│   │   └── readable.js
│   ├── balanced-pool.js
│   ├── client.js
│   ├── compat
│   │   └── dispatcher-weakref.js
│   ├── core
│   │   ├── connect.js
│   │   ├── errors.js
│   │   ├── request.js
│   │   ├── symbols.js
│   │   └── util.js
│   ├── dispatcher.js
│   ├── fetch
│   │   ├── LICENSE
│   │   ├── body.js
│   │   ├── constants.js
│   │   ├── dataURL.js
│   │   ├── file.js
│   │   ├── formdata.js
│   │   ├── headers.js
│   │   ├── index.js
│   │   ├── request.js
│   │   ├── response.js
│   │   ├── symbols.js
│   │   └── util.js
│   ├── handler
│   │   └── redirect.js
│   ├── llhttp
│   │   ├── constants.d.ts
│   │   ├── constants.js
│   │   ├── constants.js.map
│   │   ├── llhttp.wasm
│   │   ├── llhttp.wasm.js
│   │   ├── llhttp_simd.wasm
│   │   ├── llhttp_simd.wasm.js
│   │   ├── utils.d.ts
│   │   ├── utils.js
│   │   └── utils.js.map
│   ├── mock
│   │   ├── mock-agent.js
│   │   ├── mock-client.js
│   │   ├── mock-errors.js
│   │   ├── mock-interceptor.js
│   │   ├── mock-pool.js
│   │   ├── mock-symbols.js
│   │   └── mock-utils.js
│   ├── node
│   │   └── fixed-queue.js
│   ├── pool-base.js
│   ├── pool.js
│   └── proxy-agent.js
├── package.json
└── types
    ├── agent.d.ts
    ├── api.d.ts
    ├── balanced-pool.d.ts
    ├── client.d.ts
    ├── connector.d.ts
    ├── dispatcher.d.ts
    ├── errors.d.ts
    ├── fetch.d.ts
    ├── file.d.ts
    ├── formdata.d.ts
    ├── global-dispatcher.d.ts
    ├── mock-agent.d.ts
    ├── mock-client.d.ts
    ├── mock-errors.d.ts
    ├── mock-interceptor.d.ts
    ├── mock-pool.d.ts
    ├── pool.d.ts
    └── proxy-agent.d.ts

14 directories, 94 files

mcollina
mcollina approved these changes Feb 10, 2022
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
mcollina merged commit 221c6ae into nodejs:main Feb 10, 2022
@Kikobeats
Kikobeats deleted the npmignore branch February 10, 2022 17:29
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
@Kikobeats @KhafraDev
chore: ignore wasm file for npm publishing (nodejs#1219)
30ef83c
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
@Kikobeats @metcoder95
chore: ignore wasm file for npm publishing (nodejs#1219)
38f439c
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
@Kikobeats @crysmags
chore: ignore wasm file for npm publishing (nodejs#1219)
43df298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@ronag ronag ronag approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kikobeats @mcollina @ronag