Repository navigation
Add custom variable to specify a wrapper for the determined commands to launch a console - #190
Conversation
775b160 to
e87c239
Compare
| WITH-BUNDLER, the command is wrapped with `bundle exec'." | ||
| (let* ((command (format (if (string-empty-p inf-ruby-wrapper-command) "%s" inf-ruby-wrapper-command) | ||
| (concat (when with-bundler "bundle exec ") "irb -v"))) | ||
| (output (car (last (apply #'process-lines (split-string-and-unquote command))))) |
There was a problem hiding this comment.
I would have used split-string-shell-command, but that's only available starting Emacs 28.1, so I don't know if that's okay
There was a problem hiding this comment.
I think we'd rather use process-file-shell-command directly, similar to how process-lines is itself defined (but it uses call-process, which we'd replace). By calling shell command, we can avoid the need for splitting it.
LMK if this makes sense to you, and if it doesn't sound too hard.
There was a problem hiding this comment.
I'm not sure I understood this one, as process-file-shell-command doesn't seem to return the command output. I'm not sure how to, or if it's even a good idea to create a temporary buffer to capture the command output, as I'm not yet very well versed in elisp
|
Hi! Thanks for the submission, see the comments. |
…to launch a console This allows running the console inside a Docker container
e87c239 to
f6f9e72
Compare
Seems more straightforward. #190
|
Thanks, merged with minor edits (e.g. using |
2 participants
This allows running the console inside a Docker container