This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Never bundle when saving as peer/peerOptional - #255
Merged
Merged
Conversation
isaacs
force-pushed
the
isaacs/never-bundle-peers
branch
from
March 23, 2021 16:08
e582c52 to
22b2d13
Compare
This was referenced Mar 23, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bit of logic in npm/cli that sets the
saveBundleoption tofalse based on the various
--save-xyzflags. It is easier and saferto just never bundle if we're saving a peer dep, in the one place where
that decision is made.
References