Repository navigation
DOC: Inaccessible contrast for a:visited links in admonitions #26058
Description
Issue with current documentation:
- Visit https://numpy.org/neps/nep-0029-deprecation_policy.html
- If you've not visited the link "SPEC 0 — Minimum Supported Versions" before, it looks like:
- Click the link "SPEC 0 — Minimum Supported Versions"
- Return to https://numpy.org/neps/nep-0029-deprecation_policy.html
- It looks like:
The contrast of purple on the dark background is low: it's ratio is 1.51, below the WCAG AA level of 4.5:
This comes from basic.css, which I think is from Sphinx:
a:visited {
color: #551A8B;
}If I disable the rule, it looks like this, with a good ratio of 5.37:
The docs use PyData Sphinx Theme 0.13.3, but I can't reproduce the problem with these links (and inspecting the elements to edit in a link):
Activity
melissawm commentedon Mar 21, 2024
Related: scientific-python/scientific-python-hugo-theme#457
trallard commentedon Mar 22, 2024
This is fixed in the most recent versions of the theme (with the updated colour palette). So once the pin on 0.13 is removed this should no longer be a problem.
It's also related to #25927
mattip commentedon Mar 24, 2024
The pin is here. Should we pin to a newer version? Which one?
numpy/requirements/doc_requirements.txt
Line 4 in 529fd40
DOC: Bump pydata-sphinx-theme version
hugovk commentedon Mar 24, 2024
Let's go for the newest version, 0.15.2.
Please see PR #26125.
trallard commentedon Mar 24, 2024
Bringing this issue also to this conversation as it would be good to ensure both the colour and font issues mentioned in #25927 are addressed.
DOC: Bump pydata-sphinx-theme version